From owner-freebsd-current@FreeBSD.ORG Thu Aug 13 21:55:31 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 691F41065698 for ; Thu, 13 Aug 2009 21:55:31 +0000 (UTC) (envelope-from artis.caune@gmail.com) Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by mx1.freebsd.org (Postfix) with ESMTP id 89AF48FC43 for ; Thu, 13 Aug 2009 21:55:30 +0000 (UTC) Received: by bwz19 with SMTP id 19so1115069bwz.37 for ; Thu, 13 Aug 2009 14:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LLFim1lfud1KsU3wg/Nb63U/Gf8e0rxoYwUH7a7yeWA=; b=Nc2JsDmQ4iOCkdMI9wN3PszG1F/v1J18MCy1QMXuUeuUB6nL3ZrdX07uAc+YR7gCPQ yi12QG6p4I2q2Jdza0whu/0jx7m0kzie/mUxrOeIy0t+xx5hir8UG7lAlH/IdcCxL8GD 9P6urzZ5IP4MZK9sKWxbaPVjmvE3GwJKaJYCY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=DPZW5ms+iSISY5xA1g3HW+vL1IpVBadbiqUmmCSPdJohxmtFdoVjEo33uZJrK5VDYK BKZwyipnN+TNjJiVMfGobxCpQVUonuy0BIfKT+m/0hYvo+6VaKlPPT932ha8rsSCzk9p fxSvNANFA3gWWH6yc/Aq+eVF/LQkiT4BeHH9Y= MIME-Version: 1.0 Received: by 10.103.228.19 with SMTP id f19mr460782mur.63.1250200528603; Thu, 13 Aug 2009 14:55:28 -0700 (PDT) In-Reply-To: <4A846206.7010803@FreeBSD.org> References: <200903282317.n2SNHIjI015202@svn.freebsd.org> <4A846206.7010803@FreeBSD.org> Date: Fri, 14 Aug 2009 00:55:28 +0300 Message-ID: <9e20d71e0908131455x62e2d26au52b3e5b0253cdaec@mail.gmail.com> From: Artis Caune To: Doug Barton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "Bjoern A. Zeeb" , freebsd-current@freebsd.org Subject: Re: svn commit: r190514 - head/sys/conf X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 21:55:31 -0000 2009/8/13 Doug Barton : >> =C2=A0if [ -n "$svnversion" -a -d "${SRCDIR}/.svn" ] ; then >> - =C2=A0 =C2=A0 svn=3D" r`cd $SRCDIR && $svnversion`" >> + =C2=A0 =C2=A0 # If we are called from the kernel build, limit >> + =C2=A0 =C2=A0 # the scope of svnversion to sys/ . >> + =C2=A0 =C2=A0 if [ -e "${SRCDIR}/sys/conf/newvers.sh" ] ; then > > I missed this when it went through originally, so my apologies for the > late response, but I don't see any way that this first test can ever > not be true. Is there a better way to detect if the script is called > in the buildkernel process? > > Also, what problem are we really trying to solve here? With a > populated cache it takes on average 5 seconds to run all of src, and > just under 1 to do only sys. Is 4 seconds really that important to > save? With a dry cache I'm sure it takes a little longer, but has > anyone actually measured this? How about 'svn info' ? It will also hide M,S suffixes for modified and/or switched working copies. svn=3D" r`svn info $SRCDIR 2>/dev/null | awk '/^Revision:/ {print $2}'`" --=20 Artis Caune Everything should be made as simple as possible, but not simpler.