From owner-freebsd-bugs@FreeBSD.ORG Fri Oct 26 07:40:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A883216A41A for ; Fri, 26 Oct 2007 07:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 841A413C4AC for ; Fri, 26 Oct 2007 07:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9Q7e1Nv006406 for ; Fri, 26 Oct 2007 07:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9Q7e1rf006405; Fri, 26 Oct 2007 07:40:01 GMT (envelope-from gnats) Resent-Date: Fri, 26 Oct 2007 07:40:01 GMT Resent-Message-Id: <200710260740.l9Q7e1rf006405@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Danny Braniss Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E961216A420 for ; Fri, 26 Oct 2007 07:31:24 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10]) by mx1.freebsd.org (Postfix) with ESMTP id A0F8D13C4CA for ; Fri, 26 Oct 2007 07:31:24 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from sunfire.cs.huji.ac.il ([132.65.16.80]) by cs1.cs.huji.ac.il with esmtp id 1IlJf8-000FbJ-Je for FreeBSD-gnats-submit@freebsd.org; Fri, 26 Oct 2007 09:31:22 +0200 Received: from danny by sunfire.cs.huji.ac.il with local (Exim 4.68 (FreeBSD)) (envelope-from ) id 1IlJf8-0009W2-Ip for FreeBSD-gnats-submit@freebsd.org; Fri, 26 Oct 2007 09:31:22 +0200 Message-Id: Date: Fri, 26 Oct 2007 09:31:22 +0200 From: Danny Braniss To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: misc/117520: csup not-really-equivalent to cvsup X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Danny Braniss List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2007 07:40:01 -0000 >Number: 117520 >Category: misc >Synopsis: csup not-really-equivalent to cvsup >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Oct 26 07:40:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Danny Braniss >Release: FreeBSD 7.0-BETA1 amd64 >Organization: >Environment: System: FreeBSD sunfire 7.0-BETA1 FreeBSD 7.0-BETA1 #1: Sat Oct 20 16:30:43 IST 2007 danny@sunfire:/r+d/obj/sunfire/r+d/7.0/src/sys/HUJI amd64 >Description: csup parses strings differently than cvsup >How-To-Repeat: this works ok with cvsup, but not with csup *default prefix=/r+d/releng_7 >Fix: suggested fix to accept quoted string, which is definitly incomplete but shows the way. --- /r+d/7.0/src/contrib/csup/token.l 2006-03-14 05:51:10.000000000 +0200 +++ /cs/system/danny/src/csup/token.l 2007-10-26 09:22:47.815207000 +0200 @@ -67,6 +67,13 @@ err(1, "strdup"); return STRING; } +\"[^\"\n]+\" { + yylval.str = strdup(yytext+1); + if (yylval.str == NULL) + err(1, "strdup"); + yylval.str[strlen(yylval.str)-1]='\0'; + return STRING; + } \n lineno++; %% >Release-Note: >Audit-Trail: >Unformatted: