Date: Thu, 15 Oct 2015 15:57:29 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199223] [PATCH] deskutils/ganttproject: Update to version 2.7 Message-ID: <bug-199223-13-xrnlVZaLBd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-199223-13@https.bugs.freebsd.org/bugzilla/> References: <bug-199223-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199223 --- Comment #7 from Alexey Dokuchaev <danfe@FreeBSD.org> --- (In reply to tkato432 from comment #5) > It is very difficult for me to guess why the existence of PORTDATA has to be a target for criticism. Understanding it probably requires learning some of the history behind these knobs. Originally we had none of them, and provided that docs and examples are often optional, it typically had required setting PLIST_SUB in the Makefile and clumsy lines in pkg-plist: > %%PORTDOCS%%%%DOCSDIR%%some_docfile.txt > ... Docs are usually not just optional and thus require special support in Makefile/pkg-plist, they often are of little interest to grep pkg-plist for, so eventually someone proposed the idea of PORTDOCS knob which allows one to list all the docfiles in a variable and thus remove explicit support bits thereof from the Makefile and pkg-plist. (Rationale for PORTEXAMPLES is pretty much the same.) I'm not sure why PORTDATA was ever created in the same fashion as it is not the same at all. PORTDATA is essential to port's operation, so it should never be installed conditionally (there is one special case when port data assets are huge which is common for e.g. games, but in this case it's usually a better idea to split gamefoo and gamefoo-data ports). As it does not have to be installed conditionally, there's no PLIST_SUBS dances and %%-prefixed lines in pkg-plist to worry about, and last but not least, port data are a lot more interesting to grep for. That said, PORTDATA knob (particularly when used with globbing) should just die, and I prefer sooner than later. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199223-13-xrnlVZaLBd>