From owner-cvs-all@FreeBSD.ORG Fri Jul 20 13:06:56 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96BF916A41F for ; Fri, 20 Jul 2007 13:06:56 +0000 (UTC) (envelope-from chinsan.tw@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.243]) by mx1.freebsd.org (Postfix) with ESMTP id 4739513C4CE for ; Fri, 20 Jul 2007 13:06:54 +0000 (UTC) (envelope-from chinsan.tw@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so214521anc for ; Fri, 20 Jul 2007 06:06:53 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=eQV9x3S3VfVyvzKOlaxku3X8Qy7SD4Jl2AUBx2RRd3lsuky7qSy5grifnA3CfqJXd910bMwekVYJyLNbQVDFJPL8IhtM+im/2dm4UwckeM+f0/Hg0tjP089T9w4CD2gJAEdaGqu6rXy6k9PRJdYZcS7Z+lPWY9rrhQP+KEUKCBU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=orQ0Qybk33ox/R8qk9+etcYUW/L9HgbBzEBdQ415Vfza1Oey82ZmpHtHYp2cl09TexSgqPlop8UFfbouPdzMSjkkk1TAoeznz8Go5l8ytW0kLgdnb7tjxvTFxbWckjuQKm3uv23T6SWM1iQ2P0Hi2Mk+Dyj17ySx4rPoBPNz2DE= Received: by 10.100.153.17 with SMTP id a17mr214537ane.1184936813665; Fri, 20 Jul 2007 06:06:53 -0700 (PDT) Received: by 10.100.119.4 with HTTP; Fri, 20 Jul 2007 06:06:53 -0700 (PDT) Message-ID: <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com> Date: Fri, 20 Jul 2007 21:06:53 +0800 From: chinsan To: pav@freebsd.org In-Reply-To: <1184936122.13381.28.camel@pav.hide.vol.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200707201246.l6KCkC8M062760@repoman.freebsd.org> <1184936122.13381.28.camel@pav.hide.vol.cz> Cc: doc-committers@freebsd.org, cvs-doc@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2007 13:06:56 -0000 On 7/20/07, Pav Lucistnik wrote: > Chin-San Huang p=ED=9Ae v p=E1 20. 07. 2007 v 12:46 +0000: > > chinsan 2007-07-20 12:46:12 UTC > > > > FreeBSD doc repository > > > > Modified files: > > en_US.ISO8859-1/books/porters-handbook book.sgml > > Log: > > - Fix typo. > > > > "If a port insists on linking -lpthread or -lc_r directly, patch it t= o use > > PTHREAD_LIBS variable provided by the ports framework." > > > > Noticed by: kevlo > > > > Revision Changes Path > > 1.858 +1 -1 doc/en_US.ISO8859-1/books/porters-handbook/book.= sgml > > That's actually not a typo. The text should read > > on linking -pthread, -lpthread or -lc_r > > -- > Pav Lucistnik > > > Sword ownership rights have been under heavy fire since they were > determined to be the leading cause of death during the Siege of Acre > in the third crusade. Hi, Pav: The Original: @${REINPLACE_CMD} -e 's|-pthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure The patched: @${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|' ${WRKSRC}/configur= e Since "PTHREAD_LIBS?=3D -pthread", so why we should replace it again? Therefore, it was guessed as a typo of "-lpthread" instead of "-pthread". Because PTHREAD_LIBS =3D -pthread. :) The following text is just a quote "If a port insists on linking -lpthread or -lc_r directly, patch it to use PTHREAD_LIBS variable provided by the ports framework." - chinsan