From owner-svn-src-all@FreeBSD.ORG Sun Nov 2 10:34:55 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92A911065673; Sun, 2 Nov 2008 10:34:55 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id B61798FC31; Sun, 2 Nov 2008 10:34:54 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so1627500fgb.35 for ; Sun, 02 Nov 2008 02:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=rdGImoeqSeQhDee4g7TpSdOHGc1WPyrHlUETRHW9paQ=; b=j83IjEOeAbeHD2seJT6SLVc5mRallg1VaA1RA96WDnDhZDM+qS1iKxm0UDmvPTsfHs h3tdQiLSkueT6ofs4/KUaX6MznEG2L5cyIuMpo51ETfqpdpDcRx6IxtdbE+ohYMBeL8e fWYGrZYcshdk2K38dZ1bz03HaWGvFnzpJEy0A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=dcS4KRq5eBwJyTb+lQzlhzR4q2Z8gkQ2JRhMtdHzSUTVbApfASS/NcAo3hiDU+NfON 2WxK2URU6JJyY+lwwTNR/m/cEg9QjHi/TG0wnBTrWxYMVBLB6tkSkwev2UO6DbnXN0li e7Ml++tnt6Vdyr6aT+dKeZg9ipJ/N8Wjkbs3U= Received: by 10.103.193.12 with SMTP id v12mr6494750mup.87.1225622093091; Sun, 02 Nov 2008 02:34:53 -0800 (PST) Received: by 10.103.239.14 with HTTP; Sun, 2 Nov 2008 02:34:52 -0800 (PST) Message-ID: <3bbf2fe10811020234n14f554b3ld60eca8527e2647b@mail.gmail.com> Date: Sun, 2 Nov 2008 11:34:52 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Bjoern A. Zeeb" In-Reply-To: <20081102102108.B41609@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811021015.mA2AFgim036178@svn.freebsd.org> <20081102102108.B41609@maildrop.int.zabbadoz.net> X-Google-Sender-Auth: 2636d8c535ef211c Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184554 - in head/sys: geom/journal gnu/fs/ext2fs kern nfsclient sys ufs/ffs ufs/ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2008 10:34:55 -0000 2008/11/2, Bjoern A. Zeeb : > On Sun, 2 Nov 2008, Attilio Rao wrote: > > > > Author: attilio > > Date: Sun Nov 2 10:15:42 2008 > > New Revision: 184554 > > URL: http://svn.freebsd.org/changeset/base/184554 > > > > Log: > > Improve VFS locking: > > - Implement real draining for vfs consumers by not relying on the > > mnt_lock and using instead a refcount in order to keep track of lock > > requesters. > > - Due to the change above, remove the mnt_lock lockmgr because it is now > > useless. > > - Due to the change above, vfs_busy() is no more linked to a lockmgr. > > Change so its KPI by removing the interlock argument and defining 2 new > > flags for it: MBF_NOWAIT which basically replaces the LK_NOWAIT of the > > old version (which was unlinked from the lockmgr alredy) and > > MBF_MNTLSTLOCK which provides the ability to drop the mountlist_mtx > > once the mnt interlock is held (ability still desired by most > consumers). > > - The stub used into vfs_mount_destroy(), that allows to override the > > mnt_ref if running for more than 3 seconds, make it totally useless. > > Remove it as it was thought to work into older versions. > > If a problem of "refcount held never going away" should appear, we will > > need to fix properly instead than trust on such hackish solution. > > - Fix a bug where returning (with an error) from dounmount() was still > > leaving the MNTK_MWAIT flag on even if it the waiters were actually > > woken up. Just a place in vfs_mount_destroy() is left because it is > > going to recycle the structure in any case, so it doesn't matter. > > - Remove the markercnt refcount as it is useless. > > > > This patch modifies VFS ABI and breaks KPI for vfs_busy() so manpages and > > __FreeBSD_version will be modified accordingly. > > > > So why didn't you update __FreeBSD_version with the same commit that > changed the KPI? I just prefer to split "managing" stuff from the tecnical content. Attilio -- Peace can only be achieved by understanding - A. Einstein