From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 23 19:42:18 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D924F106567A for ; Tue, 23 Mar 2010 19:42:18 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id ADF398FC1B for ; Tue, 23 Mar 2010 19:42:18 +0000 (UTC) Received: by pvc7 with SMTP id 7so2250850pvc.13 for ; Tue, 23 Mar 2010 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=0cTaLJUKioTU9dMSm2vtsdmqyax/YrAJ5CWzmZMTiVU=; b=sCLl0HdOSjEjK5rHZEce+tBHC4BFn2mVwTqmIrLgcrwTQRRqPtC8aSMnJzjRBe116J yAw+t//PibEuT8Wb2J+vVCI0GC/4M4/KEZ91slsBWUaBzDEntKGFiLZEUDovFuWd5v69 9j4xjFeTGIccD0OZyTV6SJmwgcEDzziynoPOc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=F+9vkOnY44f+GM/2R6JzNFiigstgv2vzKizY29zZR4oLPDRNspTP40VQ9jiRBw8Z96 LaRP1UF9fmIQkSpR3iKoUvufz+Rsg+9o6VXtBkeHel0EnVCxcU4Mo2guMgz16iTsJuxA 8QXA9fPESsWGu0Nigbw//Asr6AIzj9VQ6E8is= MIME-Version: 1.0 Received: by 10.141.188.8 with SMTP id q8mr6732745rvp.0.1269373338022; Tue, 23 Mar 2010 12:42:18 -0700 (PDT) In-Reply-To: <20100324062626.C5129@delplex.bde.org> References: <201003220940.o2M9e21m037918@freefall.freebsd.org> <20100324062626.C5129@delplex.bde.org> Date: Tue, 23 Mar 2010 12:42:17 -0700 Message-ID: <7d6fde3d1003231242i4c33fb1erbc5492a9d3db0219@mail.gmail.com> From: Garrett Cooper To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Garrett Cooper , freebsd-bugs@freebsd.org Subject: Re: bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR environment variable to a location with at least 0 bytes X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2010 19:42:18 -0000 On Tue, Mar 23, 2010 at 12:26 PM, Bruce Evans wrote: > On Mon, 22 Mar 2010, Garrett Cooper wrote: > >> =A0 =A0Functions as expected provided test added in >> http://p4web.freebsd.org/chv.cgi?CH=3D175930 ; I'm just making one minor >> style change from the previous patch so that errx(3) in find_play_pen >> exits with EXIT_FAILURE instead of 2 (I agree that EXIT_FAILURE is >> synonymous to 2, but for it's more readable and consistent as >> EXIT_FAILURE). > > EXIT_FAILURE is 1. Excellent point -_-... should I just revert this then or leave it as-is? Thanks, -Garrett