From nobody Thu Jan 19 09:15:41 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NyH6P72ytz3125m for ; Thu, 19 Jan 2023 09:15:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NyH6P4ynvz49lJ for ; Thu, 19 Jan 2023 09:15:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674119741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1C5+sxQS1q1j5KKF0TZbYh2B1OJx/gJLsJjEcPcs9xA=; b=YN5fsPWF5LzpVVIBXRR1MsIQVZRY29M77NRST7DWKN+Pc4CEjpECFqEEF1cnPQIzuV7EOY t+I37C4E6UwtGnfjYiSoVUGmCwPw+NW0oe9ckQUpaveIokRu+tWW1xu0vwmT/26GPInrCa NPB467KrOUFetjDnnBocuTDlu1DOSZvxWXQG8AKng0BE/lUwxbIbwbgFJIuDVudbNNZtSQ Wom9ABUU6/8+SM8WHLxRKhRTwDZzFhh6raPDxGH+ml+KZotFVmjkqDsBr5XWd/871lKqzA LEc2lpA7uqZvkKFvMY06LCBKW0BTOLakXiTlmoLgz2K4RC0NpH07y0pZHJBKpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674119741; a=rsa-sha256; cv=none; b=lANKyBdrTLwlqBf1lZwzrZOi4SuUEA8jd/5U9XnPRzraXNBxQGDEes1pz+FUfSBtK9fa9V UchIiDjpYw6GK7nQwvpTMtAgpVWCIuk8XLeYI9kZNAXA873FS3jnny1Guu64dgUKZyn0w0 oJ3Cz8Sq00CK9OcMBJeNW8tVKqYIaDG71Ym076UTgVkr/5U7aebv5ydV55xug0QSopkq0g 06IMaT75kXxZvYPEVIULqWbr2vlC/W2ip7LcdVxubWBIEquaU3NGD6tiXB7L0wxliWQn2C DxsC1qXzPWJIG5y2DghVpT+wb0A80FQp5oakkdby3eSTrSzvA+N6pZvNq1/kmg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NyH6P3wYrzlTg for ; Thu, 19 Jan 2023 09:15:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30J9Ff41037428 for ; Thu, 19 Jan 2023 09:15:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30J9FfqA037427 for ports-bugs@FreeBSD.org; Thu, 19 Jan 2023 09:15:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269048] textproc/libucl: build fails if devel/uthash is installed (also textproc/py-ucl) Date: Thu, 19 Jan 2023 09:15:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269048 Bug ID: 269048 Summary: textproc/libucl: build fails if devel/uthash is installed (also textproc/py-ucl) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com CC: bofh@freebsd.org, zi@FreeBSD.org CC: bofh@freebsd.org, zi@FreeBSD.org Created attachment 239584 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D239584&action= =3Dedit [patch] fix build if devel/uthash installed; unbreak SIGNATURES; use libfet= ch instead of libcurl, etc. textproc/libucl has a compile error if devel/uthash is installed: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D . . libtool: compile: cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -I../ut= hash -I../src -I../include -I../uthash -I../klib -Wall -W -Wno-unused-parameter -Wno-pointer-sign -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -= MT libucl_la-ucl_emitter_utils.lo -MD -MP -MF .deps/libucl_la-ucl_emitter_utils.Tpo -c ucl_emitter_utils.c -fPIC -DPIC -o .libs/libucl_la-ucl_emitter_utils.o ucl_emitter_utils.c:222:3: warning: implicit declaration of function 'utstring_append_c' is invalid in C99 [-Wimplicit-function-declaration] utstring_append_c (buf, c); ^ ucl_emitter_utils.c:239:2: warning: implicit declaration of function 'utstring_append_len' is invalid in C99 [-Wimplicit-function-declaration] utstring_append_len (buf, str, len); ^ ucl_emitter_utils.c:419:6: error: no member named 'pd' in 'UT_string' s->pd =3D pmem; ~ ^ . . =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This is because devel/uthash is 2.3.0 and the uthash that is bundled with libucl is 1.9.8. There is an API difference between and libucl source code = is written for the latter version. Also, textproc/py-ucl fails as well if devel/uthash is installed - in a different spot: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D . . cc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -I/usr/local/include -fstack-protector-strong -fno-strict-aliasing -fPIC -DCURL_FOUND=3D1 -Iincl= ude -Isrc -Iuthash -Iklib -c src/ucl_schema.c -o build/temp.freebsd-12.4-STABLE-20221129-amd64-cpython-39/src/ucl_schema.o src/ucl_schema.c:387:46: error: expected ')' "string is too big: %u, max= imum is: %" PRId64, =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 ^ src/ucl_schema.c:398:48: error: expected ')' "string is too short: %u, minimum is: %" PRId64, =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 ^ . . =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D See also the upstream bug https://github.com/vstakhov/libucl/issues/266 (now fixed). A difference between 2.3.0 and 1.9.8 contributes to that problem as well (described in the upstream bug). Attached is a patch that ensures that the bundled uthash header-only source code - against which the current libucl was written - is used instead of ut= hash that may be installed to ${LOCALBASE}. While here: - textproc/py-ucl: fix "second build" failure (see upstream https://github.com/vstakhov/libucl/issues/268) - Remove version restriction for USES=3Dpython in py-ucl - this python mod= ule works with any version of python. - Replace curl dependency in py-ucl with libfetch. Not only does this redu= ce dependencies, but it also matches how libucl.so is built. - SIGNATURES option has not been broken for a long time now. Fixed upstrea= m in 2020. Included in 0.8.2 release. Builds fine in poudriere or out. - Minor rearrangement of some sections based on portclippy suggested order= ing. QA: - poudriere testport (ok: libucl with default options and with LUA, SIGNATURES, URLS on; ok: py-ucl) - portlint & portclippy (ok - fewer "problems" reported) PORTREVISION bump is not necessary since this is a build fix for environmen= ts that may not be building. If the SIGNATURES option is changed to be on by default (maybe a good idea now that it is no longer broken, but not include= d in the attached patch), that would require a PORTREVISION bump. --=20 You are receiving this mail because: You are the assignee for the bug.=