From owner-svn-src-head@FreeBSD.ORG Fri Aug 9 18:25:12 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D19DF89B; Fri, 9 Aug 2013 18:25:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 90FE0289F; Fri, 9 Aug 2013 18:25:11 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id VAA05082; Fri, 09 Aug 2013 21:25:09 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1V7rN7-0008ah-DO; Fri, 09 Aug 2013 21:25:09 +0300 Message-ID: <520533CD.6030109@FreeBSD.org> Date: Fri, 09 Aug 2013 21:24:13 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130708 Thunderbird/17.0.7 MIME-Version: 1.0 To: obrien@FreeBSD.org Subject: Re: svn commit: r253996 - in head: . sys/cddl/compat/opensolaris/sys sys/cddl/dev/dtrace sys/conf sys/modules/cyclic sys/modules/dtrace/dtio sys/modules/dtrace/dtmalloc sys/modules/dtrace/dtnfscl sys/m... References: <201308061551.r76FpuY7056153@svn.freebsd.org> <20130809154829.GA12485@dragon.NUXI.org> In-Reply-To: <20130809154829.GA12485@dragon.NUXI.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Aug 2013 18:25:12 -0000 on 09/08/2013 18:48 David O'Brien said the following: > On Tue, Aug 06, 2013 at 03:51:56PM +0000, Andriy Gapon wrote: >> Log: > .. >> Also, meaning of DEBUG was overloaded to enable WITNESS support for some >> OpenSolaris (primarily ZFS) locks. Now this overloading is removed and >> that use of DEBUG is replaced with a new option OPENSOLARIS_WITNESS. > > You state there is little value in witness tracking for ZFS in UPDATING. That's not completely true. If there is a new report then it deserves attention. The problem is that there are just too many reports. So probably only someone hacking on ZFS and knowing where to look / what to suspect can benefit from OPENSOLARIS_WITNESS. > Is there no reasonable way to gain useful lock tracking for ZFS? Honestly - I don't know. > At a minimum, shouldn't this also be added to sys/conf/NOTES in the > "# SMP Debugging Options:" section? This commit has not changed status quo. But what you suggest does make sense. -- Andriy Gapon