From nobody Wed May 21 19:31:35 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b2hPM5slrz5wPlB; Wed, 21 May 2025 19:31:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b2hPM5RtPz3X2H; Wed, 21 May 2025 19:31:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747855895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kd2yIEt79rJAbix1z3B8UKy+dX+8FF7QgTmyBXzuhNw=; b=ifK4AKjup1uxESE6EHoMTGcAvbwOJoMfrQBSe7mzFr2kd8ZIhbxUBh9L+U23p1Ns/tpFuj HDkrJXBDHOQDKOYy9wyAHYKqNwIm2MwbS/d66qKwb5Jy7B3L5MMiXfvlJ4qhX36euwa1gB 7WoYnusopfbUBVsZkqw89Z0y9USMwZ69/YHpxnR8cwtVWIvAi4BAiGbBN8lEBaa7TmiHqI HBGa0gHoHMcYH9WvF8ckESuCMMSmqwy9Sc/OtCQdqDLWHj9JhJTHcT1bIm55hHv5jcH4GZ X+3vwAdZLCwSpD7f6LZ6cw6Rnv7n1vlUvkeaj4X14TzqikAShxt1dvTTuKmrXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747855895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kd2yIEt79rJAbix1z3B8UKy+dX+8FF7QgTmyBXzuhNw=; b=IgMH7bqbm+qNJV0PiSy5gS/0PC88dQdDRsPeMX/nRst+4JR4v+UCYqs6vZXUhi2SMxbPjZ gcfuwlKBCJrMUHnTRFfXxkw74enKJrZQaqtY21oTINqQwch//JlNCIYKErAN6lPWdwbkgK c30dgsqoSPmWqoirktqYpAJl88b+3khgXiUJp2FmxFX8oQwCli/wKuKbndt95RF0aZAQFP LHAzCRg3RmlsIGoUQ9XpEc3PDMX1N7mM21Uq4csTB072plPAcB8fBtql370gSTgGrir4Dp OoxhL/7j/81NE0yijnzJD+iB92TDDSOKhNFs+zjxsaDDrINPfUnt95vWotPz9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747855895; a=rsa-sha256; cv=none; b=qaGOka0UnXEkym7PgDlcYYvJVtyeTK5EtJiBB2zk4r/uLglYKsoebxcjnm0R/WXotK1X2v 1DlZUapY2qMASDZUL4IUITgxKUx5W04go1uLCVOhLF1/yOZRvKClrC1OuzeDGrrpiqABl2 MZWKkoSOIOrb+yxhJos4nScTzGr4IgR0dPpJgdXE+ZfrfI0pXHOVfixtyKQHQ/KHtowPPB B2yqb4wbr4+FhtWmBwSx1lIVh1bpxpj9bA/M51GcJ2kq5BswE77FtqtX4hrSeGX3I4uiEM XlmQUavTPR5P+7u/1yfjfmFn8mDzbkWGuOAGFAggr+847e+g2g3AX1Fgdv/hyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b2hPM529wzp17; Wed, 21 May 2025 19:31:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54LJVZH4077785; Wed, 21 May 2025 19:31:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54LJVZ4H077782; Wed, 21 May 2025 19:31:35 GMT (envelope-from git) Date: Wed, 21 May 2025 19:31:35 GMT Message-Id: <202505211931.54LJVZ4H077782@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: ac86e65e0e25 - main - sndctl(8): Remove unnecessary val variable from sysctl functions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ac86e65e0e25a3e3fd6f91b17d2db874cea83c3b Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=ac86e65e0e25a3e3fd6f91b17d2db874cea83c3b commit ac86e65e0e25a3e3fd6f91b17d2db874cea83c3b Author: Christos Margiolis AuthorDate: 2025-05-21 19:31:17 +0000 Commit: Christos Margiolis CommitDate: 2025-05-21 19:31:17 +0000 sndctl(8): Remove unnecessary val variable from sysctl functions No functional change intended. Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50397 --- usr.sbin/sndctl/sndctl.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/usr.sbin/sndctl/sndctl.c b/usr.sbin/sndctl/sndctl.c index f362ce840cf7..412ea33e5adf 100644 --- a/usr.sbin/sndctl/sndctl.c +++ b/usr.sbin/sndctl/sndctl.c @@ -662,12 +662,11 @@ static int sysctl_int(const char *buf, const char *arg, int *var) { size_t size; - const char *val = arg; int n, prev; - n = strtol(val, NULL, 10); + n = strtol(arg, NULL, 10); if (errno == EINVAL || errno == ERANGE) { - warn("strtol(%s)", val); + warn("strtol(%s)", arg); return (-1); } @@ -699,7 +698,6 @@ static int sysctl_str(const char *buf, const char *arg, char *var, size_t varsz) { size_t size; - const char *val = arg; char prev[BUFSIZ]; char *tmp; @@ -710,10 +708,10 @@ sysctl_str(const char *buf, const char *arg, char *var, size_t varsz) return (-1); } - size = strlen(val); + size = strlen(arg); /* Apply new value. */ - if (sysctlbyname(buf, NULL, 0, val, size) < 0) { - warn("sysctlbyname(%s, %s)", buf, val); + if (sysctlbyname(buf, NULL, 0, arg, size) < 0) { + warn("sysctlbyname(%s, %s)", buf, arg); return (-1); } /* Get size of new string. */