From owner-svn-src-all@FreeBSD.ORG Sat Nov 22 11:29:54 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3125B1065670; Sat, 22 Nov 2008 11:29:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id B97F28FC08; Sat, 22 Nov 2008 11:29:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1L3qgS-000DbQ-90; Sat, 22 Nov 2008 13:29:52 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mAMBTnLu046787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 22 Nov 2008 13:29:49 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mAMBTnOb072172; Sat, 22 Nov 2008 13:29:49 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mAMBTngD072171; Sat, 22 Nov 2008 13:29:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 22 Nov 2008 13:29:49 +0200 From: Kostik Belousov To: Kip Macy Message-ID: <20081122112949.GA6408@deviant.kiev.zoral.com.ua> References: <200811220555.mAM5tuIJ007781@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline In-Reply-To: <200811220555.mAM5tuIJ007781@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1L3qgS-000DbQ-90 ba306028f5f1162f008c9ee52dd14592 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185162 - in head: . sys/amd64/include sys/arm/include sys/conf sys/dev/bce sys/dev/cxgb sys/dev/cxgb/sys sys/dev/cxgb/ulp/iw_cxgb sys/dev/mxge sys/dev/nxge sys/i386/include sys/i386/in... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2008 11:29:54 -0000 --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 22, 2008 at 05:55:56AM +0000, Kip Macy wrote: > Author: kmacy > Date: Sat Nov 22 05:55:56 2008 > New Revision: 185162 > URL: http://svn.freebsd.org/changeset/base/185162 >=20 > Log: > - bump __FreeBSD version to reflect added buf_ring, memory barriers, > and ifnet functions > =20 > - add memory barriers to > Modified: head/sys/i386/include/atomic.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/i386/include/atomic.h Sat Nov 22 01:48:20 2008 (r185161) > +++ head/sys/i386/include/atomic.h Sat Nov 22 05:55:56 2008 (r185162) > @@ -32,6 +32,21 @@ > #error this file needs sys/cdefs.h as a prerequisite > #endif > =20 > + > +#if defined(I686_CPU) > +#define mb() __asm__ __volatile__ ("mfence;": : :"memory") > +#define wmb() __asm__ __volatile__ ("sfence;": : :"memory") > +#define rmb() __asm__ __volatile__ ("lfence;": : :"memory") > +#else > +/* > + * do we need a serializing instruction? > + */ > +#define mb() > +#define wmb() > +#define rmb() > +#endif > + > + > /* > * Various simple operations on memory, each of which is atomic in the > * presence of interrupts and multiple processors. AFAIR, sfence instruction was added with the Pentium III processor (SSE), while lfence was introduced with the Pentium 4 (SSE2). I think that #ifdef I686_CPU handling of the fences is wrong. We need to use a serialized instruction on CPUs that does not support corresponding fence, if needed. --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkkn7SwACgkQC3+MBN1Mb4h8wACfVEKbjr0rNd5NS/gEQvt6jqHW gWoAnjKiPP1SnrpY8Q9OoELavQ16Ew8n =I9l2 -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND--