From owner-svn-src-all@FreeBSD.ORG Thu Dec 5 05:15:40 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 38AC674E; Thu, 5 Dec 2013 05:15:40 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F021A1D91; Thu, 5 Dec 2013 05:15:39 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa02.fnfis.com (8.14.5/8.14.5) with ESMTP id rB55Fd4S007855 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 4 Dec 2013 23:15:39 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.7]) by LTCFISWMSGHT06.FNFIS.com ([10.132.206.17]) with mapi id 14.03.0158.001; Wed, 4 Dec 2013 23:15:37 -0600 From: "Teske, Devin" To: Baptiste Daroussin Subject: Re: svn commit: r258854 - head/usr.sbin/bsdconfig/share Thread-Topic: svn commit: r258854 - head/usr.sbin/bsdconfig/share Thread-Index: AQHO8XkI9VtZKccGz0+IdtjvOVlorw== Date: Thu, 5 Dec 2013 05:15:36 +0000 Message-ID: References: <201312021902.rB2J2x0o032333@svn.freebsd.org> <20131204091248.GQ27759@ithaqua.etoilebsd.net> In-Reply-To: <20131204091248.GQ27759@ithaqua.etoilebsd.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: text/plain; charset="us-ascii" Content-ID: <3659770730A13C4DBB305148CED56426@fisglobal.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.72, 1.0.14, 0.0.0000 definitions=2013-12-05_01:2013-12-05,2013-12-05,1970-01-01 signatures=0 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "Teske, Devin" , Glen Barber , "svn-src-head@freebsd.org" , Devin Teske X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Devin Teske List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2013 05:15:40 -0000 On Dec 4, 2013, at 1:12 AM, Baptiste Daroussin wrote: > On Mon, Dec 02, 2013 at 07:02:59PM +0000, Glen Barber wrote: >> Author: gjb >> Date: Mon Dec 2 19:02:58 2013 >> New Revision: 258854 >> URL: http://svnweb.freebsd.org/changeset/base/258854 >>=20 >> Log: >> Fix PKG_ABI detection in bsdconfig(8) after pkg-1.2 is released, since >> the format of 'pkg -vv' output has changed. >>=20 >> MFC after: 3 days >> Sponsored by: The FreeBSD Foundation >>=20 >> Modified: >> head/usr.sbin/bsdconfig/share/common.subr >>=20 >> Modified: head/usr.sbin/bsdconfig/share/common.subr >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/usr.sbin/bsdconfig/share/common.subr Mon Dec 2 18:47:57 2013 (= r258853) >> +++ head/usr.sbin/bsdconfig/share/common.subr Mon Dec 2 19:02:58 2013 (= r258854) >> @@ -65,7 +65,7 @@ export UNAME_R=3D"$(uname -r)" # Release L >> if [ ! "${PKG_ABI+set}" ]; then >> export PKG_ABI=3D"$( >> ASSUME_ALWAYS_YES=3D1 pkg -vv | >> - awk '$1=3D=3D"ABI:"{print $2;exit}' 2> /dev/null >> + awk '$1=3D=3D"ABI"{print $3;exit}' 2> /dev/null >> )" >> fi >=20 > You have: > "pkg config abi" now :) that should allow you do avoid the awk :) >=20 Excellent. When can (or should) I start coding for these enhancements? Is it OK to code for them in HEAD? Is there a limit to MFC for these features? --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.