From owner-cvs-ports@FreeBSD.ORG Fri Aug 27 15:25:45 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EEB4E16A5D4; Fri, 27 Aug 2004 15:25:44 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6F3E43D5D; Fri, 27 Aug 2004 15:25:44 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.13.1/8.12.11) with ESMTP id i7RFPiUZ059621; Fri, 27 Aug 2004 08:25:44 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i7RFPf5P059619; Fri, 27 Aug 2004 08:25:41 -0700 (PDT) (envelope-from obrien) Date: Fri, 27 Aug 2004 08:25:41 -0700 From: "David O'Brien" To: Kris Kennaway Message-ID: <20040827152541.GB59283@dragon.nuxi.com> References: <200408270116.i7R1GmiF036802@repoman.freebsd.org> <20040827043857.GA16903@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040827043857.GA16903@xor.obsecurity.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gettext Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2004 15:25:45 -0000 On Thu, Aug 26, 2004 at 09:38:57PM -0700, Kris Kennaway wrote: > On Fri, Aug 27, 2004 at 01:16:48AM +0000, David E. O'Brien wrote: > > obrien 2004-08-27 01:16:48 UTC > > > > FreeBSD ports repository > > > > Modified files: > > devel/gettext Makefile > > Log: > > Add a NO_GETTEXT_OPTIONS knob. > > Several points: > > 1) You also silently removed the dependency on expat. Sorry, this was an accident. I had it removed locally from when I was testing if we need a dependency on 'expat'. I emailed ports last week if anyone knew why the dependency was needed in gettext 0.13. No one has come up with any reason yet. Nor can I find a real need for the dependency. Would you like me to 1. do a forced commit explaining why the depenancy was removed, or 2. back this part out and wait a little more time to see if someone comes up with a need for the depenancy? > 2) User control knobs of this nature must be in the WITH_*/WITHOUT_* > namespace, not NO_*. I spoke to two of the "OPTIONS" authors about adding NO_${PORTNAME}_OPTIONS and they thought it was a good idea. Neither came back saying it should be spelled WITHOUT_${PORTNAME}_OPTIONS. Based on your comments, I'll rename it to WITHOUT_${PORTNAME}_OPTIONS until a knob to turn off options per-port gets implemented and committed to bsd.port.mk. > 3) This duplicates what BATCH does, as we discussed about a month ago. Yes, BATCH is very global and affects all ports. This is port specific. Much like some ports have NO__ knobs. -- -- David (obrien@FreeBSD.org)