From nobody Fri May 12 12:33:15 2023
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QHp8D1x6jz49xyK;
Fri, 12 May 2023 12:33:16 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4QHp8D1RFMz3t3D;
Fri, 12 May 2023 12:33:16 +0000 (UTC)
(envelope-from git@FreeBSD.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
t=1683894796;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=vgTWvxOYRKXSEmRrObA8XCixtgcw1rcqwrj09Y0t+n4=;
b=btbb6dNBjSW5I7LnvHdngF+TRi7FF3wEnsx0sHkLRtRwWbnkt/xmtkYyq8STDLpz8fP+3B
Xv2TpDUI/TAompigFZygb4WaSQBk0Ao9+ouwe9J1iAgW6xcdcMqvGzrqXEiNEAUytvliOa
FaUX+fvbl2M4WaOD0sPpYRDPTbXyZifvuC/YPMnbyZe1eZRb5smX4FrHfJWwJwP+NAmJ5j
oatrrFRRik9kO4EoJSIcoxWWB2VVIwpFdz9XOcPN+f1jIV9z4XqnEv5ZmsTX6G6p5keNv4
i2UjPg3Hl/JYggaKDYWJ4SgYTZgu8GEkEp40hdv/HxKZP3ch4MKEru8sK39++w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
s=dkim; t=1683894796;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=vgTWvxOYRKXSEmRrObA8XCixtgcw1rcqwrj09Y0t+n4=;
b=COJjrJfqImOwQyj4uXIN1/eI3yyglfmWtD6a1UjQwPMgy5KbGINkUVQeWweo6zeFFos26f
qkeVbEzEM58jenGlUSqx92rkaC0fNnwe+d4VUjxrLsIUtYM8O0e/kKbQgDXQ8vSYNPrzvf
zhmYEXLZtlWVkTNPv7ND9i2z/7jUsfVQ9QGDWmIWhgmczsjdhPaV77XT1uGwhmOhpo/eF+
9S1TRByyTujoHhH46xCt7kb5LGl05hI93EDFoFKIOjqSJU1JKUoz2dMFjd5ZkRouTTY3EY
EANX9TA16RNkbHck6b5ENEdpGgaPuqQCVKH019ZMjp0GhPqHcks8lySKSb+myA==
ARC-Authentication-Results: i=1;
mx1.freebsd.org;
none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683894796; a=rsa-sha256; cv=none;
b=YRTajYnJyK1lcKTt2SlXYdIZ7bt8V6rDaYzs74DLJRkaeYMzhOynEJPAG9x9l0txRTNyB0
81FWPjBWEhJeXAqZam/B+f8EggMuaod6xvCIQWXeKV3w4UyY4F+h+V3doeoh/KOZkPcJ+L
CURqrv0n18+k4Yr4NbR/gJTpk/fT/pDj/DDmReb2S1/rjBiDwknc6Bir0cHD27BzG1I/3k
eaOe43Q3qGQbZJ/AfOhiocfaVKEQf4Jn1OatDNQ/KfgiMNliH3x3VVwzu2wNF/hDnzViZM
XEDCunksSxBZ+YKthCq1oau1FKv5DLyqLQypkcc+8UQK8dYll/0ZCt81x7Hisw==
Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QHp8D0VNxzbmg;
Fri, 12 May 2023 12:33:16 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from gitrepo.freebsd.org ([127.0.1.44])
by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34CCXFuY049710;
Fri, 12 May 2023 12:33:15 GMT
(envelope-from git@gitrepo.freebsd.org)
Received: (from git@localhost)
by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34CCXF32049709;
Fri, 12 May 2023 12:33:15 GMT
(envelope-from git)
Date: Fri, 12 May 2023 12:33:15 GMT
Message-Id: <202305121233.34CCXF32049709@gitrepo.freebsd.org>
To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
dev-commits-src-main@FreeBSD.org
From: Kristof Provost <kp@FreeBSD.org>
Subject: git: fa554de7746d - main - netlink: reduce default log levels
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-main@freebsd.org
X-BeenThere: dev-commits-src-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Git-Committer: kp
X-Git-Repository: src
X-Git-Refname: refs/heads/main
X-Git-Reftype: branch
X-Git-Commit: fa554de7746d88959738e4cb978608af8ce479c1
Auto-Submitted: auto-generated
X-ThisMailContainsUnwantedMimeParts: N
The branch main has been updated by kp:
URL: https://cgit.FreeBSD.org/src/commit/?id=fa554de7746d88959738e4cb978608af8ce479c1
commit fa554de7746d88959738e4cb978608af8ce479c1
Author: Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-05-11 13:08:42 +0000
Commit: Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-05-12 12:32:57 +0000
netlink: reduce default log levels
Reduce the default log level for netlink to LOG_INFO. This removes a
number of messages such as
> [nl_iface] dump_sa: unsupported family: 0, skipping
or
> [nl_iface] get_operstate_ether: error calling SIOCGIFMEDIA on vlan0: 22
that are useful for debugging, but not for most users.
Reviewed by: melifaro
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D40062
---
sys/compat/linux/linux_netlink.c | 2 +-
sys/netlink/netlink_domain.c | 2 +-
sys/netlink/netlink_generic.c | 2 +-
sys/netlink/netlink_generic_kpi.c | 2 +-
sys/netlink/netlink_io.c | 2 +-
sys/netlink/netlink_message_parser.c | 2 +-
sys/netlink/netlink_message_writer.c | 2 +-
sys/netlink/netlink_module.c | 2 +-
sys/netlink/netlink_route.c | 2 +-
sys/netlink/route/iface.c | 2 +-
sys/netlink/route/iface_drivers.c | 2 +-
sys/netlink/route/neigh.c | 2 +-
sys/netlink/route/nexthop.c | 2 +-
sys/netlink/route/rt.c | 2 +-
14 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/sys/compat/linux/linux_netlink.c b/sys/compat/linux/linux_netlink.c
index 775a36994d2d..85c0e6ba33a0 100644
--- a/sys/compat/linux/linux_netlink.c
+++ b/sys/compat/linux/linux_netlink.c
@@ -57,7 +57,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_linux
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
static bool
valid_rta_size(const struct rtattr *rta, int sz)
diff --git a/sys/netlink/netlink_domain.c b/sys/netlink/netlink_domain.c
index 7538336bdc45..9138e3417cf6 100644
--- a/sys/netlink/netlink_domain.c
+++ b/sys/netlink/netlink_domain.c
@@ -56,7 +56,7 @@
#define DEBUG_MOD_NAME nl_domain
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
_Static_assert((NLP_MAX_GROUPS % 64) == 0,
"NLP_MAX_GROUPS has to be multiple of 64");
diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c
index 4595b3074d50..32009e74e6a0 100644
--- a/sys/netlink/netlink_generic.c
+++ b/sys/netlink/netlink_generic.c
@@ -49,7 +49,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_generic
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
static int dump_family(struct nlmsghdr *hdr, struct genlmsghdr *ghdr,
const struct genl_family *gf, struct nl_writer *nw);
diff --git a/sys/netlink/netlink_generic_kpi.c b/sys/netlink/netlink_generic_kpi.c
index b64f6bd3f1b6..d64c53b1b3d6 100644
--- a/sys/netlink/netlink_generic_kpi.c
+++ b/sys/netlink/netlink_generic_kpi.c
@@ -45,7 +45,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_generic_kpi
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG3);
+_DECLARE_DEBUG(LOG_INFO);
/*
diff --git a/sys/netlink/netlink_io.c b/sys/netlink/netlink_io.c
index 9f5ecf63a07d..0961e6ae89d6 100644
--- a/sys/netlink/netlink_io.c
+++ b/sys/netlink/netlink_io.c
@@ -48,7 +48,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_io
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
/*
* The logic below provide a p2p interface for receiving and
diff --git a/sys/netlink/netlink_message_parser.c b/sys/netlink/netlink_message_parser.c
index c6cd82260e5b..a1551d3f3a91 100644
--- a/sys/netlink/netlink_message_parser.c
+++ b/sys/netlink/netlink_message_parser.c
@@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_parser
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
bool
nlmsg_report_err_msg(struct nl_pstate *npt, const char *fmt, ...)
diff --git a/sys/netlink/netlink_message_writer.c b/sys/netlink/netlink_message_writer.c
index ef568ecbca07..dbbbec69d9fd 100644
--- a/sys/netlink/netlink_message_writer.c
+++ b/sys/netlink/netlink_message_writer.c
@@ -47,7 +47,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_writer
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
/*
* The goal of this file is to provide convenient message writing KPI on top of
diff --git a/sys/netlink/netlink_module.c b/sys/netlink/netlink_module.c
index 6835c4a0e730..55df52fc85b6 100644
--- a/sys/netlink/netlink_module.c
+++ b/sys/netlink/netlink_module.c
@@ -52,7 +52,7 @@ FEATURE(netlink, "Netlink support");
#define DEBUG_MOD_NAME nl_mod
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
#define NL_MAX_HANDLERS 20
diff --git a/sys/netlink/netlink_route.c b/sys/netlink/netlink_route.c
index ce0c0eb36dbc..1fd6d5da63a9 100644
--- a/sys/netlink/netlink_route.c
+++ b/sys/netlink/netlink_route.c
@@ -44,7 +44,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_route_core
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
#define HANDLER_MAX_NUM (NL_RTM_MAX + 10)
static const struct rtnl_cmd_handler *rtnl_handler[HANDLER_MAX_NUM] = {};
diff --git a/sys/netlink/route/iface.c b/sys/netlink/route/iface.c
index aaed11e637a2..adcf58b72e1b 100644
--- a/sys/netlink/route/iface.c
+++ b/sys/netlink/route/iface.c
@@ -59,7 +59,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_iface
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
struct netlink_walkargs {
struct nl_writer *nw;
diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c
index 6f6adc323be6..cebbb07b5cac 100644
--- a/sys/netlink/route/iface_drivers.c
+++ b/sys/netlink/route/iface_drivers.c
@@ -57,7 +57,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_iface_drivers
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
/*
* Generic modification interface handler.
diff --git a/sys/netlink/route/neigh.c b/sys/netlink/route/neigh.c
index db72bc9bfd4e..ced2c74284e3 100644
--- a/sys/netlink/route/neigh.c
+++ b/sys/netlink/route/neigh.c
@@ -52,7 +52,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_neigh
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
static int lle_families[] = { AF_INET, AF_INET6 };
diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c
index 94cc6caf7d82..2a1585616e07 100644
--- a/sys/netlink/route/nexthop.c
+++ b/sys/netlink/route/nexthop.c
@@ -56,7 +56,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_nhop
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
/*
* This file contains the logic to maintain kernel nexthops and
diff --git a/sys/netlink/route/rt.c b/sys/netlink/route/rt.c
index cbe9ee001dfd..01a7d7ed3e16 100644
--- a/sys/netlink/route/rt.c
+++ b/sys/netlink/route/rt.c
@@ -52,7 +52,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_route
#define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h>
-_DECLARE_DEBUG(LOG_DEBUG);
+_DECLARE_DEBUG(LOG_INFO);
static unsigned char
get_rtm_type(const struct nhop_object *nh)