From owner-svn-src-all@freebsd.org Tue Oct 15 17:35:00 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A6DD14F45B; Tue, 15 Oct 2019 17:35:00 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46t2cf4wPpz4ZTG; Tue, 15 Oct 2019 17:34:58 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 9c06c68a; Tue, 15 Oct 2019 19:34:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=TaaBAv9m826az+Oad0zC+Z0kWV4=; b=Lnd5+co4j4n1KFYs+F6KyTwVSc+P L3sW4Wlp66Tj4pQC6XbhUceR9CEQI7GEeVNOeSgFGnT0XxDmXrHmIIc9v0mqGFaj cMZjqLqXe1JK2HS87OuF+/NmO9D0B7SqA/V3aULuvrplFvS060+tS1UdGTao3Cl5 KEB/0Z5MMeVPblI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=rX4Pp37uphxABRlqg6eg1r2KGX2natbV9ljwPOr/vYuPhY8/dwYSqQR/ mYw9ubEzVMZaRl9fS8Xtg6ybWq6xKhhWmLl2F16Ng9XB9dGU9BlP8fWKkPBWTKqP 5Axd0uIGpy+iJlZ3ltbWzi5FNpl6CDT9YzfHKGxvgX0OqZZvD4k= Received: from sonic.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 96216a0c TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Tue, 15 Oct 2019 19:34:51 +0200 (CEST) Date: Tue, 15 Oct 2019 19:34:51 +0200 From: Emmanuel Vadot To: Ruslan Bukin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353575 - head/sys/dev/mmc/host Message-Id: <20191015193451.f7c9388f971432e6d1be369b@bidouilliste.com> In-Reply-To: <201910151724.x9FHOM55015499@repo.freebsd.org> References: <201910151724.x9FHOM55015499@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46t2cf4wPpz4ZTG X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=Lnd5+co4; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-1.18 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.69)[-0.687,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.972,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.38)[ip: (-0.67), ipnet: 212.83.160.0/19(2.45), asn: 12876(0.11), country: FR(-0.00)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2019 17:35:00 -0000 On Tue, 15 Oct 2019 17:24:22 +0000 (UTC) Ruslan Bukin wrote: > Author: br > Date: Tue Oct 15 17:24:21 2019 > New Revision: 353575 > URL: https://svnweb.freebsd.org/changeset/base/353575 > > Log: > Fix dwmmc(4) driver attachment when ext_resources are not present. > > Ignore only ENOENT (no DTS properties found) and ENODEV (driver not > present) non-zero return values from ext_resources. > > Reviewed by: manu > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D22043 > > Modified: > head/sys/dev/mmc/host/dwmmc.c I've just realized that you are probably using the SOCFPGA kernel configuration and it doesn't have option EXT_RESOURCES so how did you got those errors ? > Modified: head/sys/dev/mmc/host/dwmmc.c > ============================================================================== > --- head/sys/dev/mmc/host/dwmmc.c Tue Oct 15 17:17:16 2019 (r353574) > +++ head/sys/dev/mmc/host/dwmmc.c Tue Oct 15 17:24:21 2019 (r353575) > @@ -457,20 +457,32 @@ parse_fdt(struct dwmmc_softc *sc) > > /* IP block reset is optional */ > error = hwreset_get_by_ofw_name(sc->dev, 0, "reset", &sc->hwreset); > - if (error != 0 && error != ENOENT) > + if (error != 0 && > + error != ENOENT && > + error != ENODEV) { > device_printf(sc->dev, "Cannot get reset\n"); > + goto fail; > + } > > /* vmmc regulator is optional */ > error = regulator_get_by_ofw_property(sc->dev, 0, "vmmc-supply", > &sc->vmmc); > - if (error != 0 && error != ENOENT) > + if (error != 0 && > + error != ENOENT && > + error != ENODEV) { > device_printf(sc->dev, "Cannot get regulator 'vmmc-supply'\n"); > + goto fail; > + } > > /* vqmmc regulator is optional */ > error = regulator_get_by_ofw_property(sc->dev, 0, "vqmmc-supply", > &sc->vqmmc); > - if (error != 0 && error != ENOENT) > + if (error != 0 && > + error != ENOENT && > + error != ENODEV) { > device_printf(sc->dev, "Cannot get regulator 'vqmmc-supply'\n"); > + goto fail; > + } > > /* Assert reset first */ > if (sc->hwreset != NULL) { > @@ -483,8 +495,12 @@ parse_fdt(struct dwmmc_softc *sc) > > /* BIU (Bus Interface Unit clock) is optional */ > error = clk_get_by_ofw_name(sc->dev, 0, "biu", &sc->biu); > - if (error != 0 && error != ENOENT) > + if (error != 0 && > + error != ENOENT && > + error != ENODEV) { > device_printf(sc->dev, "Cannot get 'biu' clock\n"); > + goto fail; > + } > > if (sc->biu) { > error = clk_enable(sc->biu); > @@ -499,8 +515,12 @@ parse_fdt(struct dwmmc_softc *sc) > * if no clock-frequency property is given > */ > error = clk_get_by_ofw_name(sc->dev, 0, "ciu", &sc->ciu); > - if (error != 0 && error != ENOENT) > + if (error != 0 && > + error != ENOENT && > + error != ENODEV) { > device_printf(sc->dev, "Cannot get 'ciu' clock\n"); > + goto fail; > + } > > if (sc->ciu) { > if (bus_hz != 0) { -- Emmanuel Vadot