From owner-svn-ports-head@freebsd.org  Mon Nov 21 22:26:41 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79A53C4DE4D;
 Mon, 21 Nov 2016 22:26:41 +0000 (UTC) (envelope-from kwm@FreeBSD.org)
Received: from smtpq1.tb.mail.iss.as9143.net (smtpq1.tb.mail.iss.as9143.net
 [212.54.42.164])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3CF3CC9E;
 Mon, 21 Nov 2016 22:26:40 +0000 (UTC) (envelope-from kwm@FreeBSD.org)
Received: from [212.54.42.118] (helo=lsmtp4.tb.mail.iss.as9143.net)
 by smtpq1.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2)
 (envelope-from <kwm@FreeBSD.org>)
 id 1c8whV-0005dZ-Px; Mon, 21 Nov 2016 23:04:33 +0100
Received: from d34030.upc-d.chello.nl ([213.46.34.30] helo=[192.168.0.36])
 by lsmtp4.tb.mail.iss.as9143.net with esmtp (Exim 4.82)
 (envelope-from <kwm@FreeBSD.org>)
 id 1c8whV-0004q9-Mq; Mon, 21 Nov 2016 23:04:33 +0100
Message-ID: <1479765873.1459.2.camel@FreeBSD.org>
Subject: Re: svn commit: r426722 - in head/lang: . pocl pocl/files
From: Koop Mast <kwm@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Date: Mon, 21 Nov 2016 23:04:33 +0100
In-Reply-To: <882131e7-54d5-9d24-98de-3297a29c187a@FreeBSD.org>
References: <201611211436.uALEaprl096393@repo.freebsd.org>
 <882131e7-54d5-9d24-98de-3297a29c187a@FreeBSD.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Ziggo-spambar: /
X-Ziggo-spamscore: 0.0
X-Ziggo-spamreport: CMAE Analysis: v=2.2 cv=SKcybKnH c=1 sm=0 tr=0
 a=IkcTkHD0fZMA:10 a=L24OOQBejmoA:10 a=eEmJkdyKdL3hkkrPVNkA:9
 a=QEXdDO2ut3YA:10 xcat=Undefined/Undefined none
X-Ziggo-Spam-Status: No
X-Spam-Status: No
X-Spam-Flag: No
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 22:26:41 -0000

On Mon, 2016-11-21 at 19:33 +0100, Mathieu Arnold wrote:
> Le 21/11/2016 à 15:36, Koop Mast a écrit :
> > 
> > +#USES=		autoreconf gmake localbase pathfix pkgconfig
> > libtool
> > +USES=		gmake localbase ncurses pathfix pkgconfig
> > libtool:keepla
> > +
> > +#CONFIGURE_ARGS+=	--enable-pedantic
> Commented out lines in Makefiles makes you wonder about the quality
> of
> the submission, wether it is a work in progress, or a final patch

This is all mine, I did a once over before commit but I missed those
commented lines.

> > 
> > +do-test:
> > +	cd ${WRKSRC} && ${GMAKE} check
> NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should
> be
> written as:
> 
> TEST_TARGET=    check

I thik I looked up MAKE_CMD once but I don't use this that often so I
probably forgot about that. I will try to keep it in mind for the next
time. I didn't know about TEST_TARGET existence.

These problems have been corrected, thanks for your comments!

-Koop