From nobody Mon Aug 28 20:09:55 2023
X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RZM9R1Sl6z4rvRC
	for <freebsd-current@mlmmj.nyi.freebsd.org>; Mon, 28 Aug 2023 20:10:03 +0000 (UTC)
	(envelope-from rb@gid.co.uk)
Received: from mx0.gid.co.uk (mx0.gid.co.uk [194.32.164.250])
	by mx1.freebsd.org (Postfix) with ESMTP id 4RZM9Q5P11z4DMM;
	Mon, 28 Aug 2023 20:10:02 +0000 (UTC)
	(envelope-from rb@gid.co.uk)
Authentication-Results: mx1.freebsd.org;
	none
Received: from smtpclient.apple (moriarty.gid.co.uk [194.32.164.17])
	by mx0.gid.co.uk (8.14.2/8.14.2) with ESMTP id 37SK9tKd014246;
	Mon, 28 Aug 2023 21:09:55 +0100 (BST)
	(envelope-from rb@gid.co.uk)
Content-Type: text/plain;
	charset=us-ascii
List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-current
List-Help: <mailto:freebsd-current+help@freebsd.org>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Subscribe: <mailto:freebsd-current+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-current+unsubscribe@freebsd.org>
Sender: owner-freebsd-current@freebsd.org
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: zfs autotrim default to off now
From: Bob Bishop <rb@gid.co.uk>
In-Reply-To: <21ef6e61-8985-9c62-b400-fe4200063e35@FreeBSD.org>
Date: Mon, 28 Aug 2023 21:09:55 +0100
Cc: Pete Wright <pete@nomadlogic.org>,
        "freebsd-current@freebsd.org" <freebsd-current@FreeBSD.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F934C7A5-9848-4DB2-A80F-7537F6804363@gid.co.uk>
References: <cpzqsgncysqm4xwarzue2n6vxpzw2yl4owlcwf64mcgzleclbb@eltdofcwp6iw>
 <de2b9081-4f3b-c19b-b658-08dd9acb563d@FreeBSD.org>
 <ffa25b60-3500-6006-0a35-2b9ffd3b2c2c@nomadlogic.org>
 <21ef6e61-8985-9c62-b400-fe4200063e35@FreeBSD.org>
To: Alexander Motin <mav@FreeBSD.org>
X-Mailer: Apple Mail (2.3696.120.41.1.4)
X-Spamd-Bar: ----
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:42831, ipnet:194.32.164.0/24, country:GB]
X-Rspamd-Queue-Id: 4RZM9Q5P11z4DMM

Hi,

> On 28 Aug 2023, at 20:00, Alexander Motin <mav@FreeBSD.org> wrote:
>=20
> On 28.08.2023 13:56, Pete Wright wrote:
>> So to be clear, if we were using the default autotrim=3Denabled =
behavior we in fact weren't having our SSDs trimmed?  I think that's my =
concern, as an admin I was under the impression that it was enabled by =
default but apparently that wasn't actually happening.
>=20
> We wanted autotrim to be enabled by default, but it was not enabled, =
and it was reported as not enabled, so there should be no confusion.  =
The only confusion may have been if you tried to read the code and see =
it should have been enabled.
>=20
> --=20
> Alexander Motin

Prompted by this thread, I went to check one of my servers that predates =
the change to OpenZFS. I set autotrim=3Don at the time of the =
transition; at some point since, it had become unset (and not by me). =
The system has been upgraded from time to time and is currently running =
13.2R.=20

--
Bob Bishop
rb@gid.co.uk