From owner-svn-src-all@freebsd.org Thu Feb 4 14:52:49 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A6C8A9A834; Thu, 4 Feb 2016 14:52:49 +0000 (UTC) (envelope-from mmel@freebsd.org) Received: from mail.miracle.cz (mail.miracle.cz [193.84.128.19]) by mx1.freebsd.org (Postfix) with ESMTP id D9B9FF5; Thu, 4 Feb 2016 14:52:48 +0000 (UTC) (envelope-from mmel@freebsd.org) Received: from [193.84.128.50] (meloun.ad.miracle.cz [193.84.128.50]) by mail.miracle.cz (Postfix) with ESMTPSA id 5398A400F1; Thu, 4 Feb 2016 15:45:11 +0100 (CET) Subject: Re: svn commit: r295254 - head/sys/arm/arm To: Zbigniew Bodek References: <201602041332.u14DWTu0085871@repo.freebsd.org> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Michal Meloun X-Enigmail-Draft-Status: N0020 Organization: freebsd.org Message-ID: <56B363F7.6000003@freebsd.org> Date: Thu, 4 Feb 2016 15:45:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.miracle.cz); Thu, 04 Feb 2016 15:45:11 +0100 (CET) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 14:52:49 -0000 Yep, I'm ready to review your patch. Allow me one question in forward. How this patch affects JTAG based debugging of kernel? Mainly if I start kernel under JTAG debugger, with active breakpoints (or watchpoints). Michal Dne 04.02.2016 v 14:41 Zbigniew Bodek napsal(a): > Hello Michal, > > I have a fix for that that I will send for review soon (I need to test > in on some other platforms): > https://people.freebsd.org/~zbb/arm/other/0001-Fix-debug_monitor-code-for-older-ARMs-ARM11.patch > > > If you don't mind I will add you to the review on Phabricator. > > Best regards > zbb > > 2016-02-04 14:32 GMT+01:00 Michal Meloun >: > > Author: mmel > Date: Thu Feb 4 13:32:29 2016 > New Revision: 295254 > URL: https://svnweb.freebsd.org/changeset/base/295254 > > Log: > ARM: RPI-B kernel was broken by r294740. Make it functional again. > > Modified: > head/sys/arm/arm/debug_monitor.c > > Modified: head/sys/arm/arm/debug_monitor.c > ============================================================================== > --- head/sys/arm/arm/debug_monitor.c Thu Feb 4 12:49:28 2016 > (r295253) > +++ head/sys/arm/arm/debug_monitor.c Thu Feb 4 13:32:29 2016 > (r295254) > @@ -845,8 +845,10 @@ dbg_arch_supported(void) > { > > switch (dbg_model) { > +#ifdef not_yet > case ID_DFR0_CP_DEBUG_M_V6: > case ID_DFR0_CP_DEBUG_M_V6_1: > +#endif > case ID_DFR0_CP_DEBUG_M_V7: > case ID_DFR0_CP_DEBUG_M_V7_1: /* fall through */ > return (TRUE); > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to > "svn-src-all-unsubscribe@freebsd.org > " > >