From owner-svn-src-head@FreeBSD.ORG Fri Dec 19 05:58:21 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25B0F106564A; Fri, 19 Dec 2008 05:58:21 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from mx6.bahnhof.se (mx6.bahnhof.se [213.80.101.16]) by mx1.freebsd.org (Postfix) with ESMTP id C72788FC08; Fri, 19 Dec 2008 05:58:20 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from localhost (mx6.local [127.0.0.1]) by mx6-reinject (Postfix) with ESMTP id 8B381211097; Fri, 19 Dec 2008 06:58:19 +0100 (CET) Received: from mx6.bahnhof.se ([127.0.0.1]) by localhost (mx6.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 30499-08; Fri, 19 Dec 2008 06:58:16 +0100 (CET) Received: from [10.0.0.3] (h-85-24-219-30.NA.cust.bahnhof.se [85.24.219.30]) by mx6.bahnhof.se (Postfix) with ESMTP id 1F4EA21108B; Fri, 19 Dec 2008 06:58:15 +0100 (CET) Received: from 127.0.0.1 (AVG SMTP 8.0.176 [270.9.19/1855]); Fri, 19 Dec 2008 06:58:12 +0100 Message-ID: <494B37F4.9060302@gmail.com> Date: Fri, 19 Dec 2008 06:58:12 +0100 From: Niclas Zeising User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: Alexander Motin References: <200812182113.mBILDkwt052441@svn.freebsd.org> <494AC475.20808@gmail.com> <494AC77A.5010609@FreeBSD.org> In-Reply-To: <494AC77A.5010609@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MX6) X-Spam-Status: No, score=1.708 tagged_above=-99 required=5 tests=[DNS_FROM_RFC_POST=1.708] X-Spam-Score: 1.708 X-Spam-Level: * Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186296 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Dec 2008 05:58:21 -0000 Alexander Motin wrote: > Niclas Zeising wrote: >> Alexander Motin wrote: >>> Author: mav >>> Date: Thu Dec 18 21:13:46 2008 >>> New Revision: 186296 >>> URL: http://svn.freebsd.org/changeset/base/186296 >>> >>> Log: >>> Before modularization commit, atapci driver was attaching only to >>> devices of >>> storage class. This check was lost. It is not important for the >>> most cases, >>> but as it was reported on current@, it does important for sis >>> driver and >>> surely inportant for AHCI driver. So restore it there. >>> Submitted by: Toshikazu ICHINOSEKI, Andrey V. Elsukov >>> Discussed on: current@ >>> >>> --- head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:04:50 >>> 2008 (r186295) >>> +++ head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:13:46 >>> 2008 (r186296) >>> @@ -105,6 +105,9 @@ ata_sis_probe(device_t dev) >>> char buffer[64]; >>> int found = 0; >>> >>> + if (pci_get_class(dev) != PCIC_STORAGE) >>> + return (ENXIO); >>> + >>> if (pci_get_vendor(dev) != ATA_SIS_ID) >>> return ENXIO; >> >> With this change, am I able to boot from a harddrive located on a >> SiS-controller again? Or is that more likely a different issue? >> I have't investigated my issue properly due to lack of time, so I >> don't know exactly what's wrong, only that it can't find the hard >> drive properly. > > I have no idea what your problem is, I am just a man. :) But if your > problem appeared on 8-CURRENT about two months ago, then it may be it > and so may be solved. > Apparently you're more than a man :). I just wanted you to know that the fix worked, my harddrives located on the SiS controller are detected again, thanks a lot for the catch! Regards! //Niclas