Date: Mon, 3 Sep 2018 19:10:43 +0000 (UTC) From: Adriaan de Groot <adridg@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r478913 - head/deskutils/charmtimetracker/files Message-ID: <201809031910.w83JAh1o025931@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adridg Date: Mon Sep 3 19:10:43 2018 New Revision: 478913 URL: https://svnweb.freebsd.org/changeset/ports/478913 Log: Fix build of deskutils/charmtimetracker with clang7. The patches contain an explanation of the error (but I don't know why clang7 complains like this or why writing out what looks like a default constructor to me gets it to be quiet). No PORTREVISION because it doesn't make a difference on any platform that already built successfully. Added: head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.cpp (contents, props changed) head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.h (contents, props changed) Added: head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.cpp Mon Sep 3 19:10:43 2018 (r478913) @@ -0,0 +1,18 @@ +Fix build with clang7: + + WeeklyTimesheet.cpp:287:37: error: default initialization of an object of const type 'const Lotsofcake::Configuration' requires a user-provided default constructor + const Lotsofcake::Configuration configuration; + +--- Charm/Lotsofcake/Configuration.cpp.orig 2018-09-03 18:53:25 UTC ++++ Charm/Lotsofcake/Configuration.cpp +@@ -43,6 +43,10 @@ static void setValueIfNotNull(QSettings + } + } + ++Lotsofcake::Configuration::Configuration() ++{ ++} ++ + bool Lotsofcake::Configuration::isConfigured() const + { + return !username().isEmpty(); Added: head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/deskutils/charmtimetracker/files/patch-Charm_Lotsofcake_Configuration.h Mon Sep 3 19:10:43 2018 (r478913) @@ -0,0 +1,16 @@ +Fix build with clang7: + + WeeklyTimesheet.cpp:287:37: error: default initialization of an object of const type 'const Lotsofcake::Configuration' requires a user-provided default constructor + const Lotsofcake::Configuration configuration; + +--- Charm/Lotsofcake/Configuration.h.orig 2018-09-03 18:53:17 UTC ++++ Charm/Lotsofcake/Configuration.h +@@ -36,6 +36,8 @@ namespace Lotsofcake { + class Configuration + { + public: ++ Configuration(); ++ + bool isConfigured() const; + + void importFromTaskExport(const TaskExport &exporter);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809031910.w83JAh1o025931>