From owner-svn-src-head@FreeBSD.ORG Thu Jan 1 05:16:58 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 20F4E1CBD for ; Thu, 1 Jan 2015 05:16:58 +0000 (UTC) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DDD5E67B1C for ; Thu, 1 Jan 2015 05:16:57 +0000 (UTC) Received: by mail-pa0-f51.google.com with SMTP id ey11so22291888pad.38 for ; Wed, 31 Dec 2014 21:16:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=kOkVL2XIOz6RbrSOqweIIwLs0FogtGq7iuP1IVPUUg0=; b=FSBE8iGwIKrxTVUyZ0nE3b541PfL2a7U1nlj+xe1SqJGEyWW5YV5Ri7BNJmeVdCnio YWI2VVGhoPPH8BvaIkUuDHBnkfNPAzpxTHR/ol5PXX++cHeqqsd2/Gz45ERyYQrUgdUU 51OKKRzigei54xIlOPjPZu6Jl2W/lcrc1IEZihjd4CkgqI82YUdl48GVfcfAF/hPVcy1 Vb3ynpy7PH4Vqz4Iw4ht2m53xgjG9x7kxxmCEn0qP/kbbuL4UKblls7eErtErS68AEnH KqoDZgVUVARB2qn4ecoIDFZBdQqtwHNxOkNfKKbQFvjT7CzYFc1n680F34h0OEsZAA+V vnEQ== X-Gm-Message-State: ALoCoQlaPpe1vqya96lNq64BNvD+zrdmXNqHOnjfmVni9Hlzm+d0xPEoOeqTEdA8sJZv5oqM4vEn X-Received: by 10.68.138.229 with SMTP id qt5mr111845711pbb.62.1420089417180; Wed, 31 Dec 2014 21:16:57 -0800 (PST) Received: from [10.64.25.37] ([69.53.236.236]) by mx.google.com with ESMTPSA id rr9sm20120706pab.15.2014.12.31.21.16.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Dec 2014 21:16:56 -0800 (PST) Sender: Warner Losh Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b3 From: Warner Losh In-Reply-To: Date: Wed, 31 Dec 2014 22:16:53 -0700 Message-Id: <743CF9C2-4C38-44CF-8AF8-BD2EF8EBCAD7@bsdimp.com> References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, Warner Losh , svn-src-all@freebsd.org, src-committers , Dimitry Andric X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2015 05:16:58 -0000 --Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Dec 31, 2014, at 10:12 PM, Garrett Cooper = wrote: >=20 > On Dec 31, 2014, at 20:44, Garrett Cooper = wrote: >=20 >> On Dec 31, 2014, at 20:25, Warner Losh wrote: >=20 > =85 >=20 >>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit. >>=20 >> Sorry. Should have asked first. Now the build is broken on all = architectures :/. What next? >=20 > Also, that code has been in there for over a decade. It seems a bit = dangerous to remove it without at least a ports -exp or make tinderbox = run=85 True. However, this code has been wrong for a very long time since the = WARNS kris added were just for user land. Too bad the std stuff got = mixed in over the years. Warner > $ svn blame -r 231834 share/mk/bsd.kmod.mk | less > 60963 peter # $FreeBSD$ > 60963 peter > 60963 peter # Search for kernel source tree in standard places. > 130835 pjd .for _dir in ${.CURDIR}/../.. ${.CURDIR}/../../.. = ${.CURDIR}/../../../.. \ > 183736 imp ${.CURDIR}/../../../../.. /sys /usr/src/sys > 130835 pjd .if !defined(SYSDIR) && exists(${_dir}/kern/) && = exists(${_dir}/conf/kmod.mk) > 60963 peter SYSDIR=3D ${_dir} > 60963 peter .endif > 60963 peter .endfor > 130835 pjd .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || = \ > 130835 pjd !exists(${SYSDIR}/conf/kmod.mk) > 231834 imp .error Unable to locate the kernel source tree. Set = SYSDIR to override. > 60963 peter .endif > 60963 peter > 60965 peter .include "${SYSDIR}/conf/kmod.mk" > 76861 kris > 76861 kris .include > [ngie@fuji-current-amd64 /usr/src.svn]$ svn log -r 76861 > = ------------------------------------------------------------------------ > r76861 | kris | 2001-05-19 16:18:21 -0700 (Sat, 19 May 2001) | 8 lines >=20 > Bring in the WARNS directive from NetBSD, localized in a new = bsd.sys.mk > to avoid polluting sys.mk. This directive controls the addition of > compiler warning flags to CFLAGS in a relatively compiler-neutral = manner. >=20 > The idea is that WARNS can be set in Makefile.inc or in individual > Makefiles as they become clean, to prevent the introduction of new > warnings in the code. -Werror is added by default >=20 > = ------------------------------------------------------------------------ --Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUpNhFAAoJEGwc0Sh9sBEAw6AP/Rus2cyQNgRiBBJrRtG0KuU8 mTptCuUnmBS4NBQBAEMuexDYxzWxaamsKiTlkgJhnjfu2s0p/VPw7deqZJsYq0EW 7lNijQf0cbDRQVK89oEUkSf9F2JBtwpqYSSrS5LpL5LE60ghlxh3bf0ZL1bI2GSn 7VizZa6TDj3RTfB+FWXmUZoph8CypmKsBH+9ofLCdHAUeD4jLM/btZYY9zCG0UCt JEpy433YWT4bCCQv6sR+2J8X2bKTcfnaPbk/gxYQBDV6fUilD2bRCJSW/L7c1TOI 98kR7dcCtxMb2NBLe7Myyx5v7jSxQMftHrfrKBTZPF/+WAJTuxPwdUt9KyRwB9gm C2fIPh+xLl2YBmBARriKPKEy5yM5Dbhl1loO+QuskRjgc6wqssMAjnPVMrKnBnia UZZRwRLTjEXn1etp6zcv9Vp6hKUbYTKVflb4mFAtcZO9gJZ50GwzO2GROGX6OLK0 ZSeKweZcUf3uGWJBvHYKPdbYO9veoyfUI2NJZ0sEB+QsD4VM3N6++JEeYKfoDR/R cbzRBHlzFeQlxHMdxZAhkWexOA7XfzqNKc1uMtu+eytyXQede0qVnyq4AY5o8Chm xmPQABy+0MW3u0J10U22DoBMCateRNOnz1y+ElRkpOUlzBBi3i/fB7HoaM1Lx6XR Ljk96E65Fo/96ICXGk1s =hJeM -----END PGP SIGNATURE----- --Apple-Mail=_5846770E-0635-4D5D-8332-3CEE8270516C--