From owner-svn-src-stable@freebsd.org Thu Mar 16 18:59:50 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17D4ED0F23C; Thu, 16 Mar 2017 18:59:50 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-ot0-f177.google.com (mail-ot0-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7D9E1270; Thu, 16 Mar 2017 18:59:49 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-ot0-f177.google.com with SMTP id 19so67121475oti.0; Thu, 16 Mar 2017 11:59:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QISIkWLNuQDNHyORyBCvdA+aX55l0u06accpeilIufs=; b=c7Q9MjT3M/99EqJw8YgiyxjXEP8cECuLg+mz4gbZtida8VjE1WYdek816YhcnWNdvv GUolhB3+dgLElEFvIBsuFyGTayRwMaHULkve8OzKHKwEpzUt+wGsinwSsREkjjovVT7j Zvkyqi7jEJkS191AxDTkb4MgswEcito00Tl/jdZwQd/5bbW6PTL0CKTZyDdoNSibNNqw cv65FN9hi77LCQZneZ2MX4PAk77svfOSHqiDXgwlZ+tHyEb+CrNS8003cBsmyGl9m0Ca Q957RkLelifgzW6B41Pl4PX1BuHiX7TE060IsaWp6Wb8b63U23LdLbDxKJuxhvI7xm4Z b4Ew== X-Gm-Message-State: AFeK/H2sGY4iX/pIm/E+8cwjKMOWO3eTAdJJEnzyiQPhDyHy1EWT9GkWm7M9X7ujgrmY2g== X-Received: by 10.202.63.7 with SMTP id m7mr5676811oia.170.1489690783111; Thu, 16 Mar 2017 11:59:43 -0700 (PDT) Received: from mail-ot0-f169.google.com (mail-ot0-f169.google.com. [74.125.82.169]) by smtp.gmail.com with ESMTPSA id r2sm2423004ota.21.2017.03.16.11.59.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 11:59:42 -0700 (PDT) Received: by mail-ot0-f169.google.com with SMTP id x37so67004428ota.2; Thu, 16 Mar 2017 11:59:42 -0700 (PDT) X-Received: by 10.202.5.4 with SMTP id 4mr5625388oif.132.1489690782344; Thu, 16 Mar 2017 11:59:42 -0700 (PDT) MIME-Version: 1.0 References: <62C8A9FD-1EE0-4DEF-A28A-843DBBB4972A@gmail.com> <201703161409.v2GE9tx0088345@slippy.cwsent.com> <0E58B9FA-C271-44CB-90E7-AE14301EEF03@gmail.com> In-Reply-To: <0E58B9FA-C271-44CB-90E7-AE14301EEF03@gmail.com> From: Eric Joyner Date: Thu, 16 Mar 2017 18:59:31 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv To: Ngie Cooper Cc: Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 18:59:50 -0000 Ngie, It looks like what's in the commit is using an older version of netmap, so I think we're okay on that. I think the naming conflict may be due to splitting the ixgbe_netmap.c file into ixgbe_netmap.c & ixv_netmap.c, and not having the functions in ixv_netmap.c be renamed. I don't think the PCI_IOV stuff should be left in there. At least from what I gathered in D4767, it's probably abandoned in 10. Cy, Are you using special options in your kernel config file? "device ixgbe" works for me, so I want to assume you have "device netmap" in your config file, unless you're missing INET and/or INET6. On Thu, Mar 16, 2017 at 10:00 AM Ngie Cooper wrote: > > On Mar 16, 2017, at 09:29, Eric Joyner wrote: > > I'm looking at this now. > > Cy, in your case it sounds like the "device ixgbe" option is broken. I'll > work on getting that to build again. > > The LINT build error looks like a netmap linking issue (probably due to > Jeb moving/copying netmap stuff into the driver folder), so that'll be fun > to root cause. > > > Hi Eric, > One sandtrap to be aware of is r307394 (and corresponding commits) > not being MFCed, along with a host of PCI-IOV, etc changes not being easily > backportable. > If you can, look for commits from me in the r29xxxx series citing > ix_crcstrip (it was a backport from bz@ to unbreak LINT on head that also > fixed stable/10). > Thanks! > -Ngie > > On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert > wrote: > > In message <62C8A9FD-1EE0-4DEF-A28A-843DBBB4972A@gmail.com>, "Ngie Cooper > (yane > urabeya)" writes: > > > > --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5 > > Content-Transfer-Encoding: quoted-printable > > Content-Type: text/plain; > > charset=us-ascii > > > > > > > On Mar 15, 2017, at 14:20, Eric Joyner wrote: > > >=20 > > > Author: erj > > > Date: Wed Mar 15 21:20:17 2017 > > > New Revision: 315333 > > > URL: https://svnweb.freebsd.org/changeset/base/315333 > > >=20 > > > Log: > > > ixgbe(4): Update to 3.2.11-k > > >=20 > > > Includes: > > >=20 > > > 1. Support for X553 (Denverton) Ethernet devices. > > > 2. Initialization code refactoring. > > > 3. ixgbe-specific netmap code moved to ixgbe folder > > > (but not removed from dev/netmap/). > > > 4. VF driver full split. Some cleanup can be had due to redundant = > > code, > > > but this split goes inline with the refactoring. > > >=20 > > > NOTE: This is a direct commit to stable/10. Newer branches will = > > receive an > > > iflib-converted version of ixgbe, with these updates included, = > > instead. > > >=20 > > > Differential Revision: https://reviews.freebsd.org/D9310 > > > Submitted by: Jeb Cramer (jeb.j.cramer@intel.com) > > > Tested by: Jeffrey Pieper (jeffrey.e.pieper@intel.com) > > > Sponsored by: Intel Corporation > > > > Hi Eric, > > This commit broke amd64/LINT, further (there are other issues = > > preventing it from passing): = > > https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console . > > It also broke buildkernel while building the ixgbe module in my > stable10/amd64 VM. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > >