From nobody Wed Sep 17 20:48:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cRrTG3mCCz683Hj; Wed, 17 Sep 2025 20:48:34 +0000 (UTC) (envelope-from ivy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cRrTG3Czdz3GSH; Wed, 17 Sep 2025 20:48:34 +0000 (UTC) (envelope-from ivy@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758142114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tOYLYKZ0YqbAW9ep2bkVWe52EKPXTcNeL9ttiYcWE5k=; b=IJOmrluocJ26CsxIVmZlMCP8DxJQuYTGjta/xmcj8AMdWcOx2RCKHVn1Gh8dpoxm4tOq3f gRKv2hTb6Nf5K1Y8/earPruTxYjkpOH/WCZ1R6Swza1JoC/utpaa0FFbbHJzYlq93jnwD0 FFC6zl52QvVyYYXZhHGo2FMw5sVnuM9PrSkb82cNzVdK2kLZq3IuE8IeaspWdOd3Y3sMvH bFXVku6vlJAgYcpdFa80Acg79PlNEJ7mPrxZh9TCzuYp5A13x8xR6BuNCrUdzAEoBr6zZz wERKIMvUbaLmAQbm5uI55DsHZPaD08DABIQCTYFPMVyK6T27eYXymLgjO+vIPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758142114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tOYLYKZ0YqbAW9ep2bkVWe52EKPXTcNeL9ttiYcWE5k=; b=ZDcjvp5aqDwu/TaAuyYpd+oLNtQkWViLGGzCXAkqusS0tzG2F9KzNwv2/6RjFcR7ROoMBm 1XLNxSU38Fk/X8zJSd+Vukmbb4uoxW/y1RkfwJusDhIYRO3CoRxntJl82DnAj+rJDEo4Zh vmeYDoEIYf00jMMB+wUV+l3LwTU0GXocwBR48NW2q1GeWUfLXsaBb4ll5fXNav2Y14JvQC VhWTxFhVMhngBf4527qzervGXX87Xm9jrURYY4pAVjq8yQCRc7vIRrki3iEFpUHqUp737c /RIGR0ggjebD4MxSvPpYVRkTDAVUs8MpU5fCyu5VQE3PiWYGiasUeF9gM6eDZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758142114; a=rsa-sha256; cv=none; b=AsjjItvhXQhiYIkGbDRMMEec3bpuKTvFYZdXufy08GFsXJD1wpfD7tv7pFAFT1Veps2kLC WgqUqmJTXGQFKLzyW0UkBmmfHKrJ5C2m6DjaPV8clro9j5DJgPmtZDJDKpNzzKr4W8wPS5 FID3KD4ZdHlNCiuTHAC12I8jXtZjWQuN6vDOBvtXZfD8qQJN+9xlTjGOGyPMH1kuIA5WWJ QeCLCW1UVm0TTTkvfg8LxTQ79qgFGfUtoB5478AwBOLKhie4nQ7CPqHZyWJwOlKwUw/bcb Cy1mY7LBFzwmu01Zm9B9Htx5S1hpfhaozRccuveRJVwjhRJr8tOb1IDc0r7RZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from amaryllis.le-fay.org (amaryllis.le-fay.org [IPv6:2a00:1098:6b:400::9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: ivy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cRrTF6KCSz4yl; Wed, 17 Sep 2025 20:48:33 +0000 (UTC) (envelope-from ivy@freebsd.org) Date: Wed, 17 Sep 2025 21:48:27 +0100 From: Lexi Winter To: "Enji Cooper (yaneurabeya)" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 9537aa02f404 - main - packages: Mark all sets as vital Message-ID: Mail-Followup-To: "Enji Cooper (yaneurabeya)" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202509172032.58HKWfxp028171@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bc92YJQSj8SFyY8D" Content-Disposition: inline In-Reply-To: --Bc92YJQSj8SFyY8D Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Enji Cooper (yaneurabeya) wrote in : > On Sep 17, 2025, at 1:32=E2=80=AFPM, Lexi Winter wrote: > > packages: Mark all sets as vital > > I actually wouldn=E2=80=99t consider `src` or `tests` to be vital (many > users don=E2=80=99t install them on their systems). Is there a reason > why they should be considered vital that I=E2=80=99m not aware of? I=E2= =80=99ve > not been paying a ton of attention to work being done in the > pkg-base space, so I might have missed some important points. "vital" doesn't mean they have to be installed, it only means that once they are installed, they can only be removed explicitly (using -f): # pkg remove freebsd-set-tests Checking integrity... done (0 conflicting) The following package(s) are locked or vital and may not be removed: FreeBSD-set-tests originally i only marked "minimal" and "base" as vital, but based on review feedback, we decided to mark all the sets as vital for now. the reason is to avoid something like this: # pkg install freebsd-set-devel # pkg remove freebsd-lldb # this also removes freebsd-set-devel ... 6 months later ... # pkg autoremove (now all the other packages installed by freebsd-set-devel are also removed.) marking the sets as vital means that users have to explicitly opt-in to removing the set if they remove a dependency of the set, which avoids this exciting behaviour. there is a pkg(8) issue that means this doesn't work quite as well as it should do: https://github.com/freebsd/pkg/issues/2517, however, i still feel this is better than the alternative. --Bc92YJQSj8SFyY8D Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSyjTg96lp3RifySyn1nT63mIK/YAUCaMselwAKCRD1nT63mIK/ YPdJAQDBRdXunLGF/S7gdBiV/XNSnobevl4Hqp1Y1R6JobVu5AD/YJjPm59sgEka trIC2qtMmNcI21Azdg4Ohz4+EYRIJwU= =3Lrd -----END PGP SIGNATURE----- --Bc92YJQSj8SFyY8D--