From owner-svn-src-head@FreeBSD.ORG Sun Feb 14 13:59:01 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAC9C106566C; Sun, 14 Feb 2010 13:59:01 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CA39C8FC13; Sun, 14 Feb 2010 13:59:01 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o1EDx13d090186; Sun, 14 Feb 2010 13:59:01 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o1EDx16a090185; Sun, 14 Feb 2010 13:59:01 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201002141359.o1EDx16a090185@svn.freebsd.org> From: Konstantin Belousov Date: Sun, 14 Feb 2010 13:59:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203875 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2010 13:59:01 -0000 Author: kib Date: Sun Feb 14 13:59:01 2010 New Revision: 203875 URL: http://svn.freebsd.org/changeset/base/203875 Log: Do not leak process lock when current thread is not allowed to see target. Bumped into by: ed MFC after: 3 days Modified: head/sys/kern/kern_event.c Modified: head/sys/kern/kern_event.c ============================================================================== --- head/sys/kern/kern_event.c Sun Feb 14 12:31:28 2010 (r203874) +++ head/sys/kern/kern_event.c Sun Feb 14 13:59:01 2010 (r203875) @@ -349,8 +349,10 @@ filt_procattach(struct knote *kn) if (p == NULL) return (ESRCH); - if ((error = p_cansee(curthread, p))) + if ((error = p_cansee(curthread, p))) { + PROC_UNLOCK(p); return (error); + } kn->kn_ptr.p_proc = p; kn->kn_flags |= EV_CLEAR; /* automatically set */