From owner-freebsd-current@FreeBSD.ORG Sat Jan 14 14:01:03 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD2B9106566B; Sat, 14 Jan 2012 14:01:03 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 33F1C8FC0C; Sat, 14 Jan 2012 14:01:02 +0000 (UTC) Received: by eeke53 with SMTP id e53so911764eek.13 for ; Sat, 14 Jan 2012 06:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lKhfniFKWWO11T8j04th08eaMaa83R2CNkozzZUdKBs=; b=YMgFvq065Pzyqcxe9x9yvzE6/rKYy3yR7czvy44BYDV2haVY7MvWkfwDet7ljLsqPX EuCXI0HXS4aof+xGxJUGRQ8ZWBVtNDFOZ1BTJlCENvRNyH4O27C60lWGVfOwhDTKg0GK yCJDuMAPIukLuz5vxvVaXDrHqA5VPC6x7ZDQE= Received: by 10.213.28.69 with SMTP id l5mr1442998ebc.110.1326549661907; Sat, 14 Jan 2012 06:01:01 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id r2sm44142324eef.7.2012.01.14.06.00.57 (version=SSLv3 cipher=OTHER); Sat, 14 Jan 2012 06:01:00 -0800 (PST) Sender: Alexander Motin Message-ID: <4F118A98.8020608@FreeBSD.org> Date: Sat, 14 Jan 2012 16:00:56 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111227 Thunderbird/9.0 MIME-Version: 1.0 To: Alexander Best References: <4F0DE3FD.2020203@FreeBSD.org> <20120112115220.1c32b3e2@ernst.jennejohn.org> <4F0EC17B.8040908@FreeBSD.org> <4F0ED27A.8070600@gwdg.de> <20120114134842.GA34133@freebsd.org> In-Reply-To: <20120114134842.GA34133@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-multimedia@FreeBSD.org, FreeBSD current Subject: Re: [RFT] Major snd_hda rewrite X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 14:01:04 -0000 On 01/14/12 15:48, Alexander Best wrote: > On Thu Jan 12 12, Rainer Hurling wrote: >> On 12.01.2012 12:18 (UTC+1), Alexander Motin wrote: >>> On 01/12/12 12:52, Gary Jennejohn wrote: >>>> On Wed, 11 Jan 2012 21:33:17 +0200 >>>> Alexander Motin wrote: >>>>> I would like request for testing of my work on further HDA sound driver >>>>> improvement. >>>> >>>> [big snip] >>>> >>>>> Patch can be found here: >>>>> http://people.freebsd.org/~mav/hda.rewrite.patch >>>>> >>>>> Patch was generated for 10-CURRENT, but should apply to fresh 9-STABLE >>>>> and 8-STABLE branches also. >>>> >>>> The patch doesn't apply cleanly to r230008; hdac.c.rej is 15661 bytes >>>> in size (mostly the section which deletes all the manufacturer-specific >>>> defines at the top of the file). >>> >>> That is probably because of $FreeBSD$ macro resolution. Here is version >>> with present value from 10-CURRENT SVN (sources from CVS or STABLE will >>> need that patch line modified respectively) and some minor additional >>> improvements like CODEC ODs and some more sysctls: >>> http://people.freebsd.org/~mav/hda.rewrite2.patch > > maybe you could try silencencing these clang warnings? > > /usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5707:25: warning: format string is not a string literal (potentially insecure) [-Wformat-security] > snprintf(buf, buflen, chans = "4.0"); > ^~~~~~~~~~~~~ > /usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5709:25: warning: format string is not a string literal (potentially insecure) [-Wformat-security] > snprintf(buf, buflen, chans = "5.1"); > ^~~~~~~~~~~~~ > /usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5711:25: warning: format string is not a string literal (potentially insecure) [-Wformat-security] > snprintf(buf, buflen, chans = "7.1"); > ^~~~~~~~~~~~~~ > /usr/subversion-src/sys/dev/sound/pci/hda/hdacc.c:563:52: warning: if statement has empty body [-Wempty-body] > if ((child = codec->streams[dir][stream]) != NULL); > ^ > 4 warning generated. > > ..i'll report how the changes interact with my system later on. Thank you! That variable is not even used now, so I'll just remove that assignment. I've passed the code through the clang static analyzer at some point, but probably I've introduced that later. -- Alexander Motin