Date: Wed, 14 Sep 1994 20:59:06 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: phk@freefall.cdrom.com (Poul-Henning Kamp) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-etc@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/etc rc Message-ID: <199409150359.UAA12673@gndrsh.aac.dev.com> In-Reply-To: <199409150221.TAA13472@freefall.cdrom.com> from "Poul-Henning Kamp" at Sep 14, 94 07:21:41 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > phk 94/09/14 19:21:40 > > Modified: etc rc > Log: > nfsiod should be started if this is a NFS-client, not if it is a server. True, and you are correct for removing it from the server startup. > look for "nfs" in etc/fstab, and start it if we see it. Not quite perfect, > but better. mount_nfs should start it, if it isn't running. Please, no, don't do that unless you are ready to fully parse the /etc/fstab and found out if that file system will be mounted (or is already mounted). proc /proc procfs rw 0 0 /dev/sd0b none swap sw 0 0 /dev/sd0a / ufs rw 1 1 /dev/sd0e /var ufs rw 1 2 /dev/sd0f /usr ufs ro 1 3 /dev/sd0g /usr/src ufs rw 1 4 /dev/sd0h /a ufs rw 1 5 #yikes:/usr /yikes/usr nfs rw,bg,soft,intr 0 0 #yikes:/work /yikes/work nfs rw,bg,soft,intr 0 0 yikes:/foo /yikes/foo nfs xx,bg,soft,intr 0 0 #/dev/sd1a /old ufs rw 1 2 #/dev/sd1e /old/var ufs rw 1 3 #/dev/sd1f /old/usr ufs rw 1 4 #/dev/sd1g /old/usr/src ufs rw 1 5 #/dev/sd1h /old/a ufs rw 1 6 If nfsiod is started with this fstab your changes are incorrect behavior. I think this should simply be done with a single know in /etc/netstart, something like nfsiod=YES. No fancy code in mount_nfs, no searching /etc/fstab, just a simple on/off switch. (This is how it is done on several other OS's, and I see no reason not to follow suite). -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199409150359.UAA12673>