From owner-freebsd-virtualization@FreeBSD.ORG  Tue Jun 19 09:10:24 2012
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4FCD31065693
	for <freebsd-virtualization@hub.freebsd.org>;
	Tue, 19 Jun 2012 09:10:24 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B02688FC2C
	for <freebsd-virtualization@hub.freebsd.org>;
	Tue, 19 Jun 2012 09:10:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5J9AHYE087615
	for <freebsd-virtualization@freefall.freebsd.org>;
	Tue, 19 Jun 2012 09:10:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5J9AHBC087614;
	Tue, 19 Jun 2012 09:10:17 GMT (envelope-from gnats)
Date: Tue, 19 Jun 2012 09:10:17 GMT
Message-Id: <201206190910.q5J9AHBC087614@freefall.freebsd.org>
To: freebsd-virtualization@FreeBSD.org
From: Daan Vreeken <Daan@vitsch.nl>
Cc: 
Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daan Vreeken <Daan@vitsch.nl>
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2012 09:10:24 -0000

The following reply was made to PR kern/158686; it has been noted by GNATS.

From: Daan Vreeken <Daan@vitsch.nl>
To: Mikolaj Golub <trociny@freebsd.org>
Cc: bug-followup@freebsd.org, "Alexander V. Chernikov" <melifaro@freebsd.org>
Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
Date: Tue, 19 Jun 2012 11:06:26 +0200

 Hi Mikolaj,
 
 On Saturday 16 June 2012 09:25:26 Mikolaj Golub wrote:
 > Hi Daan,
 >
 > The patch is committed. Thank you!
 
 Thanks for the commit!
 
 > Note, I have not committed the "FIB" part of the patch though because I am
 > not sure it was supposed to be done in this way. Your change looks
 > reasonable for me, as it looks like without it mbufs of all incoming
 > packets are not tagged on tap interface. On the other hand I don't see
 > examples in kernel where tag is set before if_input() call (only before
 > netisr_queue() or netisr_dispatch()). if_input() is actually ether_input().
 > May be it is supposed to just add this tag in ether_input()?
 >
 > I cc Alexander Chernikov, who is the author of the original patch that
 > added mbuf tagging of incoming packets (r223741), and close this pr as the
 > vimage part is fixed.
 
 I don't have a working test setup or use case at this moment where we use 
 multiple FIBs in combination with tap(4), but if I remember correctly, the 
 kernel would instantly panic upon receiving the first packet through the 
 interface without the call to M_SETFIB().
 
 If I run in to this again I'll submit a separate PR for this problem.
 
 
 Thanks,
 -- 
 Daan Vreeken
 Vitsch Electronics
 http://Vitsch.nl
 http://VitschVPN.nl
 tel: +31-(0)40-7113050
 KvK nr: 17174380