From owner-freebsd-current Wed Oct 9 19:21:55 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E96D37B401; Wed, 9 Oct 2002 19:21:54 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D95B43E3B; Wed, 9 Oct 2002 19:21:53 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g9A2LavU040455; Wed, 9 Oct 2002 19:21:43 -0700 (PDT) (envelope-from dl-freebsd@catspoiler.org) Message-Id: <200210100221.g9A2LavU040455@gw.catspoiler.org> Date: Wed, 9 Oct 2002 19:21:36 -0700 (PDT) From: Don Lewis Subject: Re: [PATCH] Re: Junior Kernel Hacker page updated... To: e0026813@stud3.tuwien.ac.at Cc: tlambert2@mindspring.com, jhb@FreeBSD.ORG, jmallett@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG In-Reply-To: <20021009225606.GC306@frog.fafoe> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 10 Oct, Stefan Farfeleder wrote: > On Tue, Oct 08, 2002 at 09:26:29PM -0700, Don Lewis wrote: >> On 8 Oct, Stefan Farfeleder wrote: >> > However, WITNESS complains (only once) about this: >> > lock order reversal >> > 1st 0xc662140c kqueue mutex (kqueue mutex) @ /freebsd/current/src/sys/kern/kern_event.c:714 >> > 2nd 0xc6727d00 pipe mutex (pipe mutex) @ /freebsd/current/src/sys/kern/sys_pipe.c:1478 >> >> That's pretty similar to the lock order reversal I've seen in the pipe >> code and it's interaction with sigio, which is not suprising since >> pipeselwakeup() calls both pgsigio() and KNOTE(), often while the pipe >> lock is held. Correctly fixing this doesn't look easy ... > > Is it just a warning or does it pose a real problem? It's a warning of a potential problem. If someone else was trying to grab the locks in the opposite order at the same time, you'd get a deadlock. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message