From owner-cvs-src@FreeBSD.ORG Fri Jan 7 19:29:23 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA38E16A4CF for ; Fri, 7 Jan 2005 19:29:23 +0000 (GMT) Received: from duchess.speedfactory.net (duchess.speedfactory.net [66.23.201.84]) by mx1.FreeBSD.org (Postfix) with SMTP id 234F743D46 for ; Fri, 7 Jan 2005 19:29:23 +0000 (GMT) (envelope-from ups@tree.com) Received: (qmail 23863 invoked by uid 89); 7 Jan 2005 19:29:21 -0000 Received: from duchess.speedfactory.net (66.23.201.84) by duchess.speedfactory.net with SMTP; 7 Jan 2005 19:29:21 -0000 Received: (qmail 16794 invoked by uid 89); 7 Jan 2005 19:26:41 -0000 Received: from unknown (HELO palm.tree.com) (66.23.216.49) by duchess.speedfactory.net with SMTP; 7 Jan 2005 19:26:41 -0000 Received: from [127.0.0.1] (localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id j07JQeNg034503; Fri, 7 Jan 2005 14:26:40 -0500 (EST) (envelope-from ups@tree.com) From: Stephan Uphoff To: Xin LI In-Reply-To: <200501060202.j0622aSw064745@repoman.freebsd.org> References: <200501060202.j0622aSw064745@repoman.freebsd.org> Content-Type: text/plain Message-Id: <1105126000.33592.47.camel@palm.tree.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 07 Jan 2005 14:26:40 -0500 Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 apic_vector.s mp_machdep.c src/sys/i386/include apicvar.h smp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2005 19:29:23 -0000 Thanks - especially for all the testing! Stephan On Wed, 2005-01-05 at 21:02, Xin LI wrote: > delphij 2005-01-06 02:02:36 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > sys/i386/i386 apic_vector.s mp_machdep.c > sys/i386/include apicvar.h smp.h > Log: > MFC IPI panic fix done by Stephan Uphoff: > sys/i386/i386/apic_vector.s 1.101 -> 1.102 > sys/i386/i386/mp_machdep.c 1.241 -> 1.243 > sys/i386/include/apicvar.h 1.8 -> 1.9 > sys/i386/include/smp.h 1.78 -> 1.79 > > To quote the original commit message: > Avoid more than two pending IPI interrupt vectors per local APIC > as this may cause deadlocks. > > This should fix kern/72123. > > Discussed with: jhb > Tested by: Nik Azim Azam, Andy Farkas, Flack Man, Aykut KARA > Izzet BESKARDES, Jens Binnewies, Karl Keusgen > Approved by: sam (mentor) > > This commit is a combination of Stephan's original one and John's style > fix on mp_machdep.c. I have tested the patch on various SMP boxes running > RELENG_5_3 (4*P3 Xeon, 2*P4 w/HTT, 2*P4 Xeon configurations) under heavy > load for a couple of weeks, so commit on behalf of Stephan when he is > on vacation. > > RELENG_5_3 candidate after settle time. > > Discussed with: ups > Reviewed by: jhb > > Revision Changes Path > 1.101.2.1 +4 -52 src/sys/i386/i386/apic_vector.s > 1.235.2.4 +65 -37 src/sys/i386/i386/mp_machdep.c > 1.8.2.1 +42 -9 src/sys/i386/include/apicvar.h > 1.78.2.1 +2 -5 src/sys/i386/include/smp.h > >