From owner-freebsd-current@FreeBSD.ORG  Fri Nov  9 12:52:21 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 53CF087A;
 Fri,  9 Nov 2012 12:52:21 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 0B6B88FC15;
 Fri,  9 Nov 2012 12:52:20 +0000 (UTC)
Received: from [192.168.0.6] (spaceball.home.andric.com [192.168.0.6])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 956D15C59;
 Fri,  9 Nov 2012 13:52:19 +0100 (CET)
Message-ID: <509CFC88.7050606@FreeBSD.org>
Date: Fri, 09 Nov 2012 13:52:24 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Greg 'groggy' Lehey <grog@FreeBSD.org>
Subject: Re: /usr/bin/calendar broken on current
References: <201211090658.qA96whII081757@pozo.com>
 <20121109072631.GQ77848@eureka.lemis.com>
In-Reply-To: <20121109072631.GQ77848@eureka.lemis.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Nov 2012 12:52:21 -0000

On 2012-11-09 08:26, Greg 'groggy' Lehey wrote:> On Thursday,  8 November 2012 at 22:58:37 -0800, Manfred Antar wrote:
>> Sometime in the last week calendar stopped working.
>> not sure the cause
>> here is some of the output:
>> /usr/share/calendar/calendar.music:231:17: warning: missing terminating ' character [-Winvalid-pp-token]
>> 12/16   Don McLean's "American Pie" is released, 1971
>>                    ^
>
> This is unexpected fallout from the transition from gcc to clang.
> calendar invokes cpp, and it seems that clang's cpp doesn't like what
> it sees.  This patch works around the issue:
>
> --- pathnames.h	(revision 242777)
> +++ pathnames.h	(working copy)
> @@ -32,5 +32,5 @@
>
>   #include <paths.h>
>
> -#define	_PATH_CPP	"/usr/bin/cpp"
> +#define	_PATH_CPP	"/usr/bin/gcpp"
>   #define	_PATH_INCLUDE	"/usr/share/calendar"
>
> Clearly that's not the solution.  I'll investigate.

Looks like yet another cpp -traditional abuse.  Clang will most likely
never support traditional preprocessing.

It is probably better to just use sed or awk for this kind of trickery.