From owner-svn-src-all@FreeBSD.ORG Wed Feb 11 04:48:43 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5363B106566C; Wed, 11 Feb 2009 04:48:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 0C8B08FC17; Wed, 11 Feb 2009 04:48:42 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n1B4lqsC060251; Tue, 10 Feb 2009 21:47:52 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 10 Feb 2009 21:47:51 -0700 (MST) Message-Id: <20090210.214751.-135505687.imp@bsdimp.com> To: sam@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <49920E67.60805@freebsd.org> References: <200902102322.n1ANMTgW007393@svn.freebsd.org> <49920E67.60805@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, mav@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r188464 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 04:48:43 -0000 In message: <49920E67.60805@freebsd.org> Sam Leffler writes: : Alexander Motin wrote: : > Author: mav : > Date: Tue Feb 10 23:22:29 2009 : > New Revision: 188464 : > URL: http://svn.freebsd.org/changeset/base/188464 : > : > Log: : > Check for device_set_devclass() errors and skip driver probe/attach if any. : > Attach call without devclass set crashes the system. : > : > On resume AHCI driver sometimes tries to create duplicate adX device. : > It is surely his own problem, but IMHO it is not a reason to crash here. : > Other reasons are also possible. : > : > : Please leave a comment in the code that this is basically a WAR for : buggy drivers. I'd personally make it a panic with a real message so that the problem gets fixed... However, I know that's a pita for people, so I'd do this only for INVARIANTS kernels. I'd whine *ALWAYS* and not just behind PDEBUG. This is a bug, and we shouldn't silently paper over it. Warner