From owner-svn-src-all@freebsd.org Tue Aug 16 13:21:17 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F22FBBB3DF for ; Tue, 16 Aug 2016 13:21:17 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 315591314 for ; Tue, 16 Aug 2016 13:21:17 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf0-x229.google.com with SMTP id h186so27703832pfg.3 for ; Tue, 16 Aug 2016 06:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=FzuQxInis9r3AweyFKzHYKIwFcjL8baaQlEANO/H5CE=; b=hRe20XuzRCr+1OdJNjv7Ld5VEEI/bSDxwEE9bXO/eBHy4mQGn48FRVUJ+xhuyD6Dck HCqMGRSmKVYEHpUSHFzFOc/KdLw4eNjf9d8+v4HnYhyvdPA9Skp0u7Zz9mI1aIfSgRfM cpiYdwptszRCMTbfqAnaiSmcfcpWwMVyJKIeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=FzuQxInis9r3AweyFKzHYKIwFcjL8baaQlEANO/H5CE=; b=Z4Seht+xEBtqdtf6Sx+zcY616DBRJUxby0FUSZgqz+sgZ6yRmA2FzNLrgwAO+s45vL VHcNyecql1PVCCM4E3rnrALdjk6zzdIf2RGGJTWknsM88iAlfZTLTlNV5rZ/fsf+0rC9 qiPgm4ye6QRUuXRektKdL9gpU+B6UpCMZ8H/KTwQpX/g5kyvxOYsZ87NZnh8DFqfIgu9 cSHvX9euIbBiqpd2CtndsQCnm33bqKYdJKUtRczltNJciWx3bd8iZ46XltK/dfnTUczz WCSuosrDLYmqXkUCmjtc/n6TUtfasgoTXaOXb4MECFrKmI5UFs6A7rb8vtQXQDC7ITW4 T1OA== X-Gm-Message-State: AEkoouvxFts3iFTE71oeJr/EGdcNqaIf6w6fxeS3eCl3ZuH7yFmhEEc3Lw4tGtXB6AvLFyIx X-Received: by 10.98.84.65 with SMTP id i62mr63584114pfb.72.1471353676616; Tue, 16 Aug 2016 06:21:16 -0700 (PDT) Received: from [100.127.65.50] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id q4sm39454475pfb.18.2016.08.16.06.21.15 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Aug 2016 06:21:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r304218 - head/sys/netinet From: Randall Stewart In-Reply-To: <20160816131805.GK22212@zxy.spb.ru> Date: Tue, 16 Aug 2016 06:21:14 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <16561701-B1C6-4BE3-B9BA-3535F564620F@netflix.com> References: <201608161240.u7GCeuWS082118@repo.freebsd.org> <20160816131805.GK22212@zxy.spb.ru> To: Slawa Olhovchenkov X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 13:21:17 -0000 In theory it *could* be MFC=E2=80=99d to stable-10 and 11 but I am not = sure we want to do that. I am told by Drew that it does improve performance since in stable-10 you are = getting the INFO_WLOCK() but I am not sure if folks want it MFC=E2=80=99d=E2=80=A6 One thing that this code leads us towards is we *in theory* could move = the lock acquisition to the timer code itself (I think).. we would have to make sure that the = callout functions did do the unlock since thats part of the lock-dance with reference=E2=80=A6 but = its theoretically possible :-) R > On Aug 16, 2016, at 6:18 AM, Slawa Olhovchenkov = wrote: >=20 > On Tue, Aug 16, 2016 at 12:40:56PM +0000, Randall Stewart wrote: >=20 >> Author: rrs >> Date: Tue Aug 16 12:40:56 2016 >> New Revision: 304218 >> URL: https://svnweb.freebsd.org/changeset/base/304218 >>=20 >> Log: >> This cleans up the timer code in TCP and also makes it so we do not >> take the INFO lock *unless* we are really going to delete the TCB. >>=20 >> Differential Revision: D7136 >=20 > Is this related to stable/10? -------- Randall Stewart rrs@netflix.com 803-317-4952