From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jan 20 15:30:05 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 851E1106566C for ; Wed, 20 Jan 2010 15:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 405F78FC25 for ; Wed, 20 Jan 2010 15:30:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0KFU5FS091466 for ; Wed, 20 Jan 2010 15:30:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0KFU5FV091463; Wed, 20 Jan 2010 15:30:05 GMT (envelope-from gnats) Resent-Date: Wed, 20 Jan 2010 15:30:05 GMT Resent-Message-Id: <201001201530.o0KFU5FV091463@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Kriventsov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C5CD10656A9 for ; Wed, 20 Jan 2010 15:23:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 528D88FC2C for ; Wed, 20 Jan 2010 15:23:22 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0KFNLZ3070267 for ; Wed, 20 Jan 2010 15:23:21 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o0KFNLVh070266; Wed, 20 Jan 2010 15:23:21 GMT (envelope-from nobody) Message-Id: <201001201523.o0KFNLVh070266@www.freebsd.org> Date: Wed, 20 Jan 2010 15:23:21 GMT From: Alexander Kriventsov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/143022: [PATCH] sysutils/puppet: fix crontab problem X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2010 15:30:05 -0000 >Number: 143022 >Category: ports >Synopsis: [PATCH] sysutils/puppet: fix crontab problem >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Jan 20 15:30:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alexander Kriventsov >Release: FreeBSD RELENG_8 >Organization: McHost >Environment: FreeBSD RELENG_8 >Description: Fix issue with crontab Original http://projects.reductivelabs.com/issues/3010 This problem was fixed in 0.25.4 >How-To-Repeat: >Fix: Patch attached with submission follows: diff -urN puppet.orig/Makefile puppet/Makefile --- puppet.orig/Makefile 2010-01-18 11:25:44.000000000 +0000 +++ puppet/Makefile 2010-01-20 15:07:16.000000000 +0000 @@ -7,6 +7,7 @@ PORTNAME= puppet PORTVERSION= 0.25.3 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= http://www.reductivelabs.com/downloads/puppet/ diff -urN puppet.orig/files/patch-lib-puppet-provider-cron-crontab.rb puppet/files/patch-lib-puppet-provider-cron-crontab.rb --- puppet.orig/files/patch-lib-puppet-provider-cron-crontab.rb 1970-01-01 00:00:00.000000000 +0000 +++ puppet/files/patch-lib-puppet-provider-cron-crontab.rb 2010-01-20 14:51:59.000000000 +0000 @@ -0,0 +1,25 @@ +--- lib/puppet/provider/cron/crontab.rb.orig 2010-01-11 23:55:13.000000000 +0000 ++++ lib/puppet/provider/cron/crontab.rb 2010-01-19 02:49:58.000000000 +0000 +@@ -27,13 +27,18 @@ + + text_line :environment, :match => %r{^\w+=} + +- crontab = record_line :crontab, :fields => %w{special minute hour monthday month weekday command}, +- :match => %r{^\s*(?:@(\w+)|(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+))\s+(.+)$}, +- :optional => %w{special minute hour weekday month monthday}, :absent => "*" ++ record_line :freebsd_special, :fields => %w{special command}, ++ :match => %r{^@(\w+)\s+(.+)$}, :pre_gen => proc { |record| ++ record[:special] = "@" + record[:special] ++ } ++ ++ crontab = record_line :crontab, :fields => %w{minute hour monthday month weekday command}, ++ :match => %r{^\s*(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(.+)$}, ++ :optional => %w{minute hour weekday month monthday}, :absent => "*" + + class << crontab + def numeric_fields +- fields - [:command, :special] ++ fields - [:command] + end + # Do some post-processing of the parsed record. Basically just + # split the numeric fields on ','. >Release-Note: >Audit-Trail: >Unformatted: