From owner-svn-ports-all@freebsd.org  Sun May  6 10:27:49 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3BAAFB591A;
 Sun,  6 May 2018 10:27:49 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FF016F5F1;
 Sun,  6 May 2018 10:27:49 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 47E1E1DFAD; Sun,  6 May 2018 10:27:49 +0000 (UTC)
Date: Sun, 6 May 2018 10:27:49 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Koichiro Iwao <meta@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace
Message-ID: <20180506102749.GA58637@FreeBSD.org>
References: <201805061015.w46AF3HQ070595@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201805061015.w46AF3HQ070595@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 May 2018 10:27:49 -0000

On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote:
> New Revision: 469188
> URL: https://svnweb.freebsd.org/changeset/ports/469188
> 
> Log:
>   ports-mgmt/pkg_replace: Update to 20180424
>   
>   - Cleanup code
>   - Speed up and strictly check package's dependencies
>   - While here, pet portlint by using pkg-plist instead of PLIST_FILES

Could you explain what did you achieve by moving three-line PLIST_FILES
into pkg-plist?  How can "pet portlint" be a reason for a change while
we generally encourage converting <6-line pkg-plist's into PLIST_FILES?

./danfe

> -
> -PLIST_FILES=	sbin/pkg_replace \
> -		man/man1/pkg_replace.1.gz \
> -		"@sample %%ETCDIR%%/pkg_replace.conf.sample"

Correct PLIST_FILES should read:

PLIST_FILES=	sbin/pkg_replace \
		man/man1/pkg_replace.1.gz \
		@sample\ etc/pkg_replace/pkg_replace.conf.sample

./danfe