From owner-svn-src-all@freebsd.org Thu Oct 26 23:35:16 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7116E55AC4 for ; Thu, 26 Oct 2017 23:35:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7BA406E3DD for ; Thu, 26 Oct 2017 23:35:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id f20so9008907ioj.9 for ; Thu, 26 Oct 2017 16:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=AIe16rq9OT4BNVLKjqd/T/USNZ+4lIqPvC1Jn6L2Tjc=; b=ON9gDyp+NEvEvdtqATne8zf+WICqa4RkqxsRn7/HoJO3+VljEyGGSMN1m9N2ufDJcS 1ixODnq4tnY6CQvaIXvwo57lMceKxFWwySbrugDc5qnBfqzsEXJ80ZVVj9ZHkWj1CfC9 kweVgAiwWBK5TDxPnZjZEl33Ab8hs7nEDdgp8FwL2iMowmnc9ly9NGCMTfHJB1TmNl4e qb2p8Gxr0N1cypDVcGK5Gfma16N8ua+VdGu73uwz6Psp5qQeAPpMoNhxBLKOuJzF/+5g h4BUPQkZerVhSG6E1xTURkpxbJ8hLT1zmVgRTs5K9veHd0zfkzqub5/5MY6rCSOcwOHp Ky5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=AIe16rq9OT4BNVLKjqd/T/USNZ+4lIqPvC1Jn6L2Tjc=; b=Z9sZvvp7M9TUTKEBeXgqXn1s9EMAypZaoeMRMxip3I2qFm4lNYNcV6aqPbexAvCKJt fgCIUzaMox0u0GKlJoWeXsRnwdVAxVWhvFWYqE/TTvGEjCFJP/wzGw70UG77DeIF8BZ/ C/I8xqU6tjh+u3sl9MycJPhhdI49KACKMFFOmXYF2nIV+9wvs6Jk/kXFoRIl+AP1OMeH 77NsLLxzHAdNeUVKcXT92j3kB4VPUttKYtOhPsQnENJLBC8reY8Hx3rKtOeH5hjKR/bL c0pukeVWDil270uP/53mSgBEmP6+Fir1+vN7roN4+lUdcpgH6h9fOu+TVgKv3UCjxyRb E92Q== X-Gm-Message-State: AMCzsaUwvy2JrWlFHHX9ZV9iDPq5sj/YVA8OFUHZN5SYhl/hNV9sSyek BEA2O8oCIkq19KBdWnnBZFqBcagB1DjbjS9tknHQiw== X-Google-Smtp-Source: ABhQp+SY+EjB/XVZjVjsnRHVHPse/UL0a5ZzjZupe5zwy3kGb1Wcps2ZS87Fihq2iz3Ub5UfMyK6+ifBZCkNaEJW0Xk= X-Received: by 10.36.94.129 with SMTP id h123mr856189itb.64.1509060915741; Thu, 26 Oct 2017 16:35:15 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Thu, 26 Oct 2017 16:35:15 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:68f3:90da:7630:94a5] In-Reply-To: References: <201710262253.v9QMrovZ009495@repo.freebsd.org> From: Warner Losh Date: Thu, 26 Oct 2017 17:35:15 -0600 X-Google-Sender-Auth: c6lfQFSKhMLnV-jKmFtJ1eSnmMU Message-ID: Subject: Re: svn commit: r325026 - head/sys/cam/ata To: Alan Somers Cc: Warner Losh , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 23:35:16 -0000 On Thu, Oct 26, 2017 at 5:04 PM, Alan Somers wrote: > On Thu, Oct 26, 2017 at 4:53 PM, Warner Losh wrote: > > Author: imp > > Date: Thu Oct 26 22:53:49 2017 > > New Revision: 325026 > > URL: https://svnweb.freebsd.org/changeset/base/325026 > > > > Log: > > Always send STANDBY IMMEDIATE when shutting down > > > > To save SMART data and for a drive to understand that it's been nicely > > shutdown, we need to send a STANDBY IMMEDIATE. Modify adaspindown to > > use a local CCB on the stack. When we're panicing, used > > xpt_polled_action rather than cam_periph_runccb so that we can SEND > > IMMEDIATE after we've shutdown the scheduler. > > > > Sponsored by: Netflix > > Reviewed by: scottl@, gallatin@ > > Differential Revision: https://reviews.freebsd.org/D12799 > > > > Modified: > > head/sys/cam/ata/ata_da.c > > Will this put the drive into a standby state just prior to a warm > reboot? That could cause lengthy delays on the new boot while the > drives spin up. That behavior caused a problem when the mpr driver > did it to a JBOD full of 96 SATA drives. On the new boot, each drive > spun up one at a time while they were being probed. Eventually the > system paniced because run_interrupt_driven_hooks timed out. With > mpr, I was able to fix the problem by setting hw.mpr.enable_ssu=0. > That's a good question. The standard is silent about what, exactly, the Standby state means. We already allow this to be disabled, and this commit doesn't change that. It looks like IDLE IMMEDIATE also forces SMART media non volatile to be flushed out. What do you suggest? Warner