From owner-svn-src-all@FreeBSD.ORG Wed Sep 19 01:06:43 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 92115106564A; Wed, 19 Sep 2012 01:06:43 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 448E814FF33; Wed, 19 Sep 2012 01:06:43 +0000 (UTC) Message-ID: <50591AA3.2050600@FreeBSD.org> Date: Tue, 18 Sep 2012 18:06:43 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Hiroki Sato References: <201209180233.q8I2XNs3022364@svn.freebsd.org> <5058036F.1010104@FreeBSD.org> <20120918.193650.1501104806829364201.hrs@allbsd.org> In-Reply-To: <20120918.193650.1501104806829364201.hrs@allbsd.org> X-Enigmail-Version: 1.4.4 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, bjk@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r240628 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2012 01:06:43 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 09/18/2012 03:36, Hiroki Sato wrote: > Doug Barton wrote > in <5058036F.1010104@FreeBSD.org>: > > do> On 09/17/2012 19:33, Benjamin Kaduk wrote: > do> > Whitespace cleanup for ipfw.8 -- start each sentence on a new line, > do> > do> We generally don't do this at all absent other changes. > do> > do> We definitely don't make whitespace-only changes mixed in with other > do> changes, as it makes the diff too hard to read. > > Please read docs/157452 before blaming the commit. The committer is responsible for what they finally commit. The mentor is responsible for review to make sure that final commit meets project guidelines. That said, Ben properly split his changes into 2 patches for the PR, so you should have been sure to tell him to commit it that way, and more importantly, WHY to commit it that way. > And I do not > think adding commas is not making the diff hard to read. That wasn't my point. Mixing ws changes with content changes makes it hard to pick out the content changes (as you well know). Doug - -- I am only one, but I am one. I cannot do everything, but I can do something. And I will not let what I cannot do interfere with what I can do. -- Edward Everett Hale, (1822 - 1909) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJQWRqjAAoJEFzGhvEaGryEt+cIAKQ0eCL/aftTelXyl6pbZT4X UlMECcMqpdQdEtbT91qz+6Pvl3HBO1OcrkywVX3kVt7WNsIKRcBoN/Ns+6Vnvagm G5wMY2MBoJO/v56S7JPC9E6O5YbYM03Fek6ZPNbGO9aIWAzjVhoW7ceN5J4cVErJ Xhtasz86HGXQVpbjmbhGT17iMvXRKHS3Nj+6C48rKr9DmNyqC2snXoY7HsLCmA/z x9GEtkbVOS+fR2REWP/6rseHCqn+MiqMtM5nMwyfHREp1noDNi2oqOtf/oDXDqAK TAWP/nv+m81gK0VFmnpHS6Z/YhhtGUyoNzryZmfpArXtML3+GzbId1R0Y+l6rmY= =O2Vn -----END PGP SIGNATURE-----