From owner-freebsd-current@FreeBSD.ORG  Wed Jul  6 21:30:52 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 99BBF16A41C;
	Wed,  6 Jul 2005 21:30:52 +0000 (GMT) (envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 614E243D53;
	Wed,  6 Jul 2005 21:30:52 +0000 (GMT) (envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.12.11) with ESMTP id j66LUoXL096618;
	Wed, 6 Jul 2005 14:30:50 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id j66LUoV5096617;
	Wed, 6 Jul 2005 14:30:50 -0700 (PDT) (envelope-from rizzo)
Date: Wed, 6 Jul 2005 14:30:50 -0700
From: Luigi Rizzo <rizzo@icir.org>
To: sos@freebsd.org, current@freebsd.org
Message-ID: <20050706143050.A96472@xorpc.icir.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
Cc: 
Subject: disksort disappeared from ATA devices in HEAD ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2005 21:30:52 -0000

I notice that the ata drivers in HEAD do not use anymore
bioq_disksort, but rather they have their own routine,
(ad_queue_request() in turn calling ata_sort_queue())
which probably does something similar.

I wonder:
1) how different is ata_sort_queue() from bioq_disksort()
   in terms of design ?
2) is there any strong reason for this change ?
3) any pointers to mail threads where this changes have been
   discussed ?

I cannot find any relevent comments browsing the code or CVS.
the change was introduced here

+++ src/sys/dev/ata/ata-disk.c	2005/03/30 12:03:37	1.183

so not long ago...

	cheers
	luigi