From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 14 10:00:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 60154B70 for ; Thu, 14 Mar 2013 10:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2F300F51 for ; Thu, 14 Mar 2013 10:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2EA01iB023365 for ; Thu, 14 Mar 2013 10:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2EA01Rv023364; Thu, 14 Mar 2013 10:00:01 GMT (envelope-from gnats) Resent-Date: Thu, 14 Mar 2013 10:00:01 GMT Resent-Message-Id: <201303141000.r2EA01Rv023364@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "r4721@tormail.org" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A7A92B27 for ; Thu, 14 Mar 2013 09:56:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 96F0EF38 for ; Thu, 14 Mar 2013 09:56:49 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2E9umEc044236 for ; Thu, 14 Mar 2013 09:56:48 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r2E9umKB044235; Thu, 14 Mar 2013 09:56:48 GMT (envelope-from nobody) Message-Id: <201303140956.r2E9umKB044235@red.freebsd.org> Date: Thu, 14 Mar 2013 09:56:48 GMT From: "r4721@tormail.org" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/176953: [patch] fix Floating Exception in recoverdisk X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2013 10:00:01 -0000 >Number: 176953 >Category: bin >Synopsis: [patch] fix Floating Exception in recoverdisk >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 14 10:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: r4721@tormail.org >Release: 9.1 stable amd64 >Organization: >Environment: >Description: the change to recoverdisk to optionally use stripesize causes Floating Exception. http://svnweb.freebsd.org/base/stable/9/sbin/recoverdisk/recoverdisk.c?r1=225736&r2=247254&view=patch pid 96884 (recoverdisk), uid 0: exited on signal 8 sectorsize and stripesize are both defined as u_int (32 bits), but the call to ioctl of DIOCGSTRIPESIZE returns a 64-bit number, overwriting the memory of sectorsize with 0, which is then used in a divison, causing a divide by zero error. attached patch simply increases stripesize to 64 bits. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: sbin/recoverdisk/recoverdisk.c =================================================================== --- sbin/recoverdisk/recoverdisk.c (revision 247608) +++ sbin/recoverdisk/recoverdisk.c (working copy) @@ -156,7 +153,7 @@ int error, state; u_char *buf; u_int sectorsize; - u_int stripesize; + u_long stripesize; time_t t1, t2; struct stat sb; u_int n, snapshot = 60; >Release-Note: >Audit-Trail: >Unformatted: