From owner-dev-commits-doc-all@freebsd.org Wed Jun 30 19:38:43 2021 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C05464A178 for ; Wed, 30 Jun 2021 19:38:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GFWqR3F5vz3lHJ; Wed, 30 Jun 2021 19:38:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 49E14127C2; Wed, 30 Jun 2021 19:38:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15UJch92057492; Wed, 30 Jun 2021 19:38:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15UJchZJ057491; Wed, 30 Jun 2021 19:38:43 GMT (envelope-from git) Date: Wed, 30 Jun 2021 19:38:43 GMT Message-Id: <202106301938.15UJchZJ057491@gitrepo.freebsd.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org From: Warner Losh Subject: git: e93b38d423 - main - committers-guide: Document "Pull Request:" lines MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: doc X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e93b38d4232b1600c17b363478a63479d8ae5b52 Auto-Submitted: auto-generated X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the doc repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 19:38:43 -0000 The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/doc/commit/?id=e93b38d4232b1600c17b363478a63479d8ae5b52 commit e93b38d4232b1600c17b363478a63479d8ae5b52 Author: Warner Losh AuthorDate: 2021-06-30 19:33:39 +0000 Commit: Warner Losh CommitDate: 2021-06-30 19:36:51 +0000 committers-guide: Document "Pull Request:" lines A number of committers have started using "Pull Request:" to document when a change was submitted by a pull request to give context discussed there should it be necessary in the future. I documented it previously in the `Landing a github pull request` section by implication as well. Sponsored by: Netflix --- documentation/content/en/articles/committers-guide/_index.adoc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index d253bd9a50..6c72d36eac 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2874,6 +2874,11 @@ Approved by: re (username) |`Sponsored by:` |Sponsoring organizations for this change, if any. Separate multiple organizations with commas. If only a portion of the work was sponsored, or different amounts of sponsorship were provided to different authors, please give appropriate credit in parentheses after each sponsor name. For example, `Example.com (alice, code refactoring), Wormulon (bob), Momcorp (cindy)` shows that Alice was sponsored by Example.com to do code refactoring, while Wormulon sponsored Bob's work and Momcorp sponsored Cindy's work. Other authors were either not sponsored or chose not to list sponsorship. +|`Pull Request:` +|This change was submitted as a pull request or merge request against one of FreeBSD's public read-only Git repositories. +It should include the entire URL to the pull request, as these often act as code reviews for the code. +For example: `https://github.com/freebsd/freebsd-src/pull/745` + |`Differential Revision:` |The full URL of the Phabricator review. This line __must be the last line__. For example: `https://reviews.freebsd.org/D1708`.