From nobody Sun Dec 24 05:07:26 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SyTYw49M5z53pMb for ; Sun, 24 Dec 2023 05:07:48 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SyTYv1wQyz4HSv for ; Sun, 24 Dec 2023 05:07:47 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-22-158.area1b.commufa.jp [123.1.22.158]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 3BO57Qiu095359; Sun, 24 Dec 2023 14:07:26 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Sun, 24 Dec 2023 14:07:26 +0900 From: Tomoaki AOKI To: d@delphij.net Cc: Xin Li , Enji Cooper , freebsd-current@freebsd.org Subject: Re: Proposal: Disable compression of newsyslog by default Message-Id: <20231224140726.4d33bdcd3ebd7414ef9dbb19@dec.sakura.ne.jp> In-Reply-To: References: Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SyTYv1wQyz4HSv On Sat, 23 Dec 2023 15:14:20 -0800 Xin Li wrote: > On 2023-12-23 07:09, Enji Cooper wrote: > > This impacts embedded systems or jails which use UFS as the default > > /var/log backed device. There are quite a few larger consumers of > > FreeBSD out there that still use UFS instead of ZFS. > > I appreciate your feedback! > > Thank you for pointing out the implications of this change for embedded > systems and jails using UFS. I understand your concerns, especially > regarding larger FreeBSD consumers who might still rely on UFS instead > of ZFS. > > Note that the committed change was designed to simplify code > maintenance, particularly for downstream software vendors. By reducing > the number of configuration lines in newsyslog.conf to a single line in > /etc/crontab, it makes it easier for downstream maintainers to follow > the latest FreeBSD codebase, because they don't have to manually solve > merge conflicts when someone changes newsyslog.conf anymore. This > should ease the integration and maintenance processes for these vendors. > > > Adding this instead into bsdinstall and the documentation as a suggested > > knob seems like a good way to go. > > > > Just something to keep in mind when making this change. > > Now back to the proposed behavior change, regarding your suggestion to > change the default in the installer, I have reservations about this > approach. One of my primary motivations for this change is to move away > from using flags to specify which compression method should be used. In > my view, the software package distributed configuration should not > dictate the compression method to be used by the user. Rather, its role > should be to inform newsyslog about the suitability of a file for > compression. This shift in approach aims to provide users with greater > flexibility and autonomy in managing their compression settings. > > Cheers, I think any config files which is updated by freebsd-update and/or etcupdate and/or mergemaster should better be in /etc/defaults and any configuration in them should be able to overridden by configuration files directly under /etc, like rc.conf. Is it possible to override EVERY configurations in /etc/newsyslog.conf by any configuration files under /etc/newsyslog.conf.d and/or /usr/local/etc/newsyslog.conf.d? If so, just moving default one to /etc/defaults would help, I think, like at commit d105b00084a533f41a1277d08cfacb15062d9b50 [1]. [1] https://cgit.freebsd.org/src/commit/?id=d105b00084a533f41a1277d08cfacb15062d9b50 Regards. -- Tomoaki AOKI