From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 29 22:52:24 2012 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EEE6106564A; Thu, 29 Mar 2012 22:52:24 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 1E36E8FC15; Thu, 29 Mar 2012 22:52:24 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id D6F1B1724D; Thu, 29 Mar 2012 15:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1333061544; bh=gn1QzA/G/ENFrEk/S4wWqrvDFOGF0IpLnsX+BhM8BL8=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=lmIrcSNUHx/aMtRTNO1AsZBBFgAXDHJI0/2AsQNkalD85BhHvHaGx9IBzaZkmTPFN UflRwjAhEIM2Pc++9verjf29x2kdJtt86wgEjXN12hkfWeTgvX73ZhngIKuvXji2UK 4snYdvSyt2nnufhYFTcALZJ1+6687PBJavAIyLsc= Message-ID: <4F74E7A7.2030603@delphij.net> Date: Thu, 29 Mar 2012 15:52:23 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: eadler@FreeBSD.org References: <201203291309.q2TD9leD067354@freefall.freebsd.org> In-Reply-To: <201203291309.q2TD9leD067354@freefall.freebsd.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@FreeBSD.org, d@delphij.net Subject: Re: bin/166483: if_nametoindex sends un-initialized bytes to ioctl X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 22:52:24 -0000 I think we would probably want to put the proposed change under #ifdef PURIFY -- the initialization is not necessary since the uninitialized part is never touched for the whole codepath. Just my $0.02. Cheers, -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die