From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 27 13:20:03 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B3F01065673 for ; Tue, 27 Apr 2010 13:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 193B98FC17 for ; Tue, 27 Apr 2010 13:20:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3RDK2LR041271 for ; Tue, 27 Apr 2010 13:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3RDK2wh041270; Tue, 27 Apr 2010 13:20:02 GMT (envelope-from gnats) Resent-Date: Tue, 27 Apr 2010 13:20:02 GMT Resent-Message-Id: <201004271320.o3RDK2wh041270@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, pluknet Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E9901065670 for ; Tue, 27 Apr 2010 13:15:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 44EED8FC1F for ; Tue, 27 Apr 2010 13:15:38 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3RDFcIB092344 for ; Tue, 27 Apr 2010 13:15:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o3RDFbBZ092343; Tue, 27 Apr 2010 13:15:37 GMT (envelope-from nobody) Message-Id: <201004271315.o3RDFbBZ092343@www.freebsd.org> Date: Tue, 27 Apr 2010 13:15:37 GMT From: pluknet To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/146086: [patch] 64-bit aware printf() fixes at tools/tools/netrate X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2010 13:20:03 -0000 >Number: 146086 >Category: misc >Synopsis: [patch] 64-bit aware printf() fixes at tools/tools/netrate >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 27 13:20:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: pluknet >Release: HEAD r207204 >Organization: >Environment: FreeBSD 9.0-CURRENT #10: Mon Apr 26 22:06:30 UTC 2010 root@xxx:/usr/obj/usr/src/sys/GENERIC amd64 >Description: 64-bit aware printf() modifier fixes in tools/tools/netrate. 1) netrate/juggle time_t has arch-dependent size 2) netrate/tcpconnect uint64_t has %lu on 64bit, but %llu on 32bit Replace these modifiers to begin with %j >How-To-Repeat: >Fix: Patch attached with submission follows: Index: tools/tools/netrate/tcpconnect/tcpconnect.c =================================================================== --- tools/tools/netrate/tcpconnect/tcpconnect.c (revision 207204) +++ tools/tools/netrate/tcpconnect/tcpconnect.c (working copy) @@ -128,8 +128,8 @@ if (try_connect(&sin) == 0) counter++; } - printf("%llu count\n", counter); - printf("%llu connections/second\n", counter / SECONDS); + printf("%ju count\n", counter); + printf("%ju connections/second\n", counter / SECONDS); return (0); } Index: tools/tools/netrate/juggle/juggle.c =================================================================== --- tools/tools/netrate/juggle/juggle.c (revision 207204) +++ tools/tools/netrate/juggle/juggle.c (working copy) @@ -557,7 +557,7 @@ if (j != 0) printf(", "); scale_timespec(&juggle_results[j], p); - printf("%u.%09lu", juggle_results[j].tv_sec, + printf("%ju.%09lu", juggle_results[j].tv_sec, juggle_results[j].tv_nsec); } printf("\n"); @@ -567,7 +567,7 @@ if (j != 0) printf(", "); scale_timespec(&process_results[j], p); - printf("%u.%09lu", process_results[j].tv_sec, + printf("%ju.%09lu", process_results[j].tv_sec, process_results[j].tv_nsec); } printf("\n"); @@ -577,7 +577,7 @@ if (j != 0) printf(", "); scale_timespec(&thread_results[j], p); - printf("%u.%09lu", thread_results[j].tv_sec, + printf("%ju.%09lu", thread_results[j].tv_sec, thread_results[j].tv_nsec); } printf("\n"); >Release-Note: >Audit-Trail: >Unformatted: