From owner-svn-src-head@freebsd.org Thu Sep 26 15:11:38 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D20861298C7; Thu, 26 Sep 2019 15:11:38 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46fJL22Ys2z4MZB; Thu, 26 Sep 2019 15:11:38 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 46fJKs6dPPz3c7b; Thu, 26 Sep 2019 15:11:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id kReIqIvfIa_a; Thu, 26 Sep 2019 15:11:29 +0000 (UTC) Received: from garnet.daemonic.se (host-95-192-147-3.mobileonline.telia.com [95.192.147.3]) by mail.daemonic.se (Postfix) with ESMTPSA id 46fJKr55krz3c7Z; Thu, 26 Sep 2019 15:11:28 +0000 (UTC) Subject: Re: svn commit: r352707 - in head/sys: conf kern net sys To: Charlie Li , Kyle Evans Cc: svn-src-head , svn-src-all , Gleb Smirnoff , src-committers , freebsd-x11@freebsd.org References: <201909251826.x8PIQVUN095257@repo.freebsd.org> <605f210b-cce2-d842-cc0c-53b76ef7dbd5@vishwin.info> <1681db78-6a0c-55cf-1e01-65e06f145975@vishwin.info> From: Niclas Zeising Message-ID: <18644033-d01e-1bc7-02eb-42999033d8fd@freebsd.org> Date: Thu, 26 Sep 2019 17:11:27 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <1681db78-6a0c-55cf-1e01-65e06f145975@vishwin.info> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46fJL22Ys2z4MZB X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.94 / 15.00]; TAGGED_RCPT(0.00)[freebsd]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.95)[-0.945,0]; ASN(0.00)[asn:36236, ipnet:2607:f740:d::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Sep 2019 15:11:38 -0000 On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote: > Kyle Evans wrote: >> On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: >>> This breaks building the drm-kmod ports, as the build cannot find >>> opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies the >>> exact same way): >>> >>> --- linux_anon_inodes.o --- >>> cc -O2 -pipe -fno-strict-aliasing -include >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/drivers/gpu/drm/drm_os_config.h >>> '-DKBUILD_MODNAME="linuxkpi_gplv2"' -Werror -D_KERNEL -DKLD_MODULE >>> -nostdinc >>> -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/include -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/dummy/include >>> -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include >>> -I/usr/src/sys/compat/linuxkpi/common/include -I. -I/usr/src/sys >>> -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer >>> -mno-omit-leaf-frame-pointer >>> -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include >>> -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD >>> -MF.depend.linux_anon_inodes.o -MTlinux_anon_inodes.o -mcmodel=kernel >>> -mno-red-zone -mno-mmx -mno-sse -msoft-float >>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector >>> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes >>> -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef >>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ >>> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas >>> -Wno-error-tautological-compare -Wno-error-empty-body >>> -Wno-error-parentheses-equality -Wno-error-unused-function >>> -Wno-error-pointer-sign -Wno-error-shift-negative-value >>> -Wno-address-of-packed-member -Wno-format-zero-length -Wno-pointer-arith >>> -mno-aes -mno-avx -std=iso9899:1999 -c >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c >>> -o linux_anon_inodes.o >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c:12: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/anon_inodes.h:4: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5: >>> In file included from >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: >>> In file included from /usr/src/sys/net/if_var.h:83: >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found >>> #include "opt_epoch.h" >>> ^~~~~~~~~~~~~ >>> --- linux_anon_inodefs.o --- >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodefs.c:45: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/debugfs.h:18: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6: >>> In file included from >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5: >>> In file included from >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: >>> In file included from /usr/src/sys/net/if_var.h:83: >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found >>> #include "opt_epoch.h" >>> ^~~~~~~~~~~~~ >>> --- linux_anon_inodes.o --- >>> 1 error generated. >>> *** [linux_anon_inodes.o] Error code 1 >>> >>> make[2]: stopped in >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi >>> --- linux_anon_inodefs.o --- >>> 1 error generated. >>> *** [linux_anon_inodefs.o] Error code 1 >>> >>> Interestingly enough, does not happen when drm-current-kmod is built as >>> part of buildkernel (using an existing installed package with SOURCE on). >>> >> >> FWIW, johalun noticed this yesterday and addressed it here: >> https://github.com/FreeBSDDesktop/kms-drm/commit/b486949e7e9f0cfe8dac5f0ac7fe1a660300981d >> > Ah, of course I would miss these commits in the kms-drm repo, > considering that I watch them roll in. Will wait for the updated > snapshots in ports. > I'll get to updating the ports as soon as I can. Regards -- Niclas Zeising