From owner-svn-src-all@freebsd.org  Sun Mar 27 16:26:55 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9821ADF0D0;
 Sun, 27 Mar 2016 16:26:55 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mailhost.stack.nl",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id AF8201298;
 Sun, 27 Mar 2016 16:26:55 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from toad2.stack.nl (toad2.stack.nl [IPv6:2001:610:1108:5010::161])
 by mx1.stack.nl (Postfix) with ESMTP id C6A61B8059;
 Sun, 27 Mar 2016 18:26:51 +0200 (CEST)
Received: by toad2.stack.nl (Postfix, from userid 1677)
 id 3BFC6892DB; Sun, 27 Mar 2016 18:26:52 +0200 (CEST)
Date: Sun, 27 Mar 2016 18:26:52 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: "Simon J. Gerraty" <sjg@juniper.net>
Cc: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@FreeBSD.org,
 svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
Subject: Re: svn commit: r296637 - in head: contrib/bmake contrib/bmake/mk
 contrib/bmake/unit-tests share/mk usr.bin/bmake
Message-ID: <20160327162652.GB87149@stack.nl>
References: <201603110135.u2B1Zd8a001604@repo.freebsd.org>
 <56E5C2EB.1070206@FreeBSD.org> <14946.1457908340@kaos.jnpr.net>
 <56E5F36E.2020205@FreeBSD.org> <15542.1457911750@kaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15542.1457911750@kaos.jnpr.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Mar 2016 16:26:56 -0000

On Sun, Mar 13, 2016 at 04:29:10PM -0700, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> > This code is only in head. My problem is now bmake can only build
> > commits after this one which breaks bisecting and older project branches
> > which haven't or can't merge in head yet.

> > Is the :@ iterator variable deletion change in bmake change necessary?

> In the sense of good hygiene, yes.
> Obviously make will work without it since its been that way for 15
> years, but this AFAIK is the only makefile affected.

I think the ability to bisect without weird local hacks is valuable,
although I rarely do this in a FreeBSD context.

-- 
Jilles Tjoelker