From owner-svn-src-stable@freebsd.org Thu Mar 15 16:36:20 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CE79F5F8D3 for ; Thu, 15 Mar 2018 16:36:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 547DE6A598 for ; Thu, 15 Mar 2018 16:36:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22c.google.com with SMTP id z7-v6so7473832iti.1 for ; Thu, 15 Mar 2018 09:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6k5fTZmJF1w4/Xnp3q5Yv57/T6w9kGFUBZqAwEfcNkI=; b=1QSWjh/F54XEjES5evUReNp7wbkT1g97mhpKAJLJ2ys/rvXVxoXP1RmVCHvURjkvwM St9uO8kM9n8jiryfCS7r7yHvTOo5RqCbAz8VL+2t8c8yk/ytDQ+iDufw5uWTFLIESHjW nB8oQSrgiufZh3E8ofahXE+UwjBIj7BkDKCXiAIRVaunyO2d6sfSiJVDgpLv3dsq3L8T noQWOKnW0650DCx0lgqsgAbjb3NByvex4Rc4tRlQqOYbWPSLBqRJNdtAmcGaprnUWod/ gsI9SCbAeX2KNxrCkik9HefxzfOYHxHTXNg0afYqbDTGGZeoElrJxKy/+5cScVWDGiG8 abaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6k5fTZmJF1w4/Xnp3q5Yv57/T6w9kGFUBZqAwEfcNkI=; b=YRmD5G2im2JxndnXNDQD7ZDtwJLgRK8b/Iq6Hdo+Kn3qCmY3KqAdchgzsLPxRG1f8b PB8oiBIVuqZkNCPJko3+HEOGdBA111jVLqSz/9GHoXnCpqpGFrGuRnJnZ5zULvpdx7Tn tjw4CouBpk7i53HLXfIK/Njoiblmdh13QjHlxL7RVPlrJXMybSX1XdWuUsDvtrUzM0TD 56qas05EBFeWXqGTJHj4kn77d1AAPNRUEH8Pxw4+GCij204g7rkJdH687uOS358O6uZ1 kwTafr1QISR+HdY0l/Zhn5avDc2Od02rPDeSoZKglOWsx1tEx7310Gg173Yfl5dAxlE/ kp5Q== X-Gm-Message-State: AElRT7H5RlwVhJziW9Ez1uzHxAqCb2vN9OeHg6BWuZsndIik/W6h57DM qV3xqvPuCP73NhXETiuojxpIoBok1GSPrTSKS1K8ZQ== X-Google-Smtp-Source: AG47ELuLeBE9ab7eCsnrxhrLVWI6IzanLSeBhJVh70/PTtkvRIg9B62XJm8ztdSf7mQ0KlKfUoP9LoKZQS2tC06vkWU= X-Received: by 2002:a24:6f04:: with SMTP id x4-v6mr960371itb.51.1521131778492; Thu, 15 Mar 2018 09:36:18 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Thu, 15 Mar 2018 09:36:17 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201803151614.w2FGEttu093805@pdx.rh.CN85.dnsmgr.net> <1521130827.99081.43.camel@freebsd.org> From: Warner Losh Date: Thu, 15 Mar 2018 10:36:17 -0600 X-Google-Sender-Auth: 0WrTGQFRDFlpuiIYbENMKcIMmF8 Message-ID: Subject: Re: svn commit: r330972 - stable/11/share/misc To: Ian Lepore Cc: "Rodney W. Grimes" , Justin Hibbits , Andriy Gapon , Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 16:36:20 -0000 On Thu, Mar 15, 2018 at 10:31 AM, Warner Losh wrote: > > > On Thu, Mar 15, 2018 at 10:20 AM, Ian Lepore wrote: > >> On Thu, 2018-03-15 at 09:14 -0700, Rodney W. Grimes wrote: >> > > >> > > On Thu, 2018-03-15 at 10:52 -0500, Justin Hibbits wrote: >> > > > >> > > > On Thu, Mar 15, 2018 at 10:46 AM, Ian Lepore >> > > > wrote: >> > > > > >> > > > > >> > > > > I agree completely with all of this.??It bothers me how many >> > > > > committers >> > > > > have the attitude that handling MFCs is not part of being a >> > > > > committer. >> > > > Never attribute to arrogance that which can adequately be >> > > > explained >> > > > by >> > > > sheer laziness ;) >> > > > >> > > > - Justin (guilty of marking changes as MFC after, and ignoring >> > > > them >> > > > for far too long) >> > > > >> > > Laziness and procrastination I understand -- I own a lovely glass >> > > house >> > > in that neighborhood. ?I tend to put off MFCs for way too long then >> > > every few months have to spend a whole weekend catching up. >> > MFC: 1 week (by pool|self) #defaults to self if missing >> > >> > There is already a very nice tracking tool for outstanding MFC's, >> > if we added a bit of smarts in its parser, and created a pool of >> > MFC commiters (Eitan seems to have started one :-)) those who >> > do not want to do there own MFC work could pass the hat. >> >> If you're talking about the MFC after: field in commits, I don't use >> it. I have about zero tolerance for being nagged by anybody about >> anything, and that goes double for robots nagging me with spam mail. >> >> The MFC tool that works well for me is gonzo's MFCTracker site [*] that >> doesn't require extra markup in the commit messages. >> > > I also have a MFC tool for git, but it's n > [[ stupid track pad and too easy button pushes... ]] but it's not ready for prime time. It's useful if you have a list of things you want to MFC for playing them onto the stable branch so you can test before committing to svn stable. It shows the big issues with moving to git as the source of truth, though. We have way too much traffic in the repo to have git cherry to produce any kind of reasonable output (too many changes, can't restrict to a subset of the tree, no way to check prior commits to files affected, etc), and the git cherry-pick command relies a bit too much on the merge magic, so it doesn't record merges (there is no merge-info in git). However, I could dust off the tool and fix up the rough edges if there's any interest at all. Kyle Evans used it to MFC my crazy src/stand stuff... Warner