From owner-svn-src-all@FreeBSD.ORG Thu Mar 1 19:35:07 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07BDC106566B; Thu, 1 Mar 2012 19:35:07 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 85F5A8FC0A; Thu, 1 Mar 2012 19:35:06 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q21JYLZw063313; Thu, 1 Mar 2012 23:34:21 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q21JYLS5063312; Thu, 1 Mar 2012 23:34:21 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 1 Mar 2012 23:34:21 +0400 From: Gleb Smirnoff To: Luigi Rizzo Message-ID: <20120301193421.GC13644@FreeBSD.org> References: <201203011735.q21HZHpi088980@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201203011735.q21HZHpi088980@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r232347 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2012 19:35:07 -0000 Luigi, On Thu, Mar 01, 2012 at 05:35:17PM +0000, Luigi Rizzo wrote: L> Author: luigi L> Date: Thu Mar 1 17:35:16 2012 L> New Revision: 232347 L> URL: http://svn.freebsd.org/changeset/base/232347 L> L> Log: L> remove some write-only variables. L> There is another block of code that is now useless as the computation L> is done in the kernel. Why ifdef dead code instead of just deleting it? -- Totus tuus, Glebius.