From owner-freebsd-rc@FreeBSD.ORG Mon Aug 10 05:05:21 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1F821065670; Mon, 10 Aug 2009 05:05:21 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 818328FC2B; Mon, 10 Aug 2009 05:05:21 +0000 (UTC) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 680A25C06F; Mon, 10 Aug 2009 13:05:20 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id F2AB655CDBF0; Mon, 10 Aug 2009 13:05:19 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id L4G2XWTUaGmP; Mon, 10 Aug 2009 13:04:26 +0800 (CST) Received: from charlie.delphij.net (c-67-188-2-183.hsd1.ca.comcast.net [67.188.2.183]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 539B655CDBF4; Mon, 10 Aug 2009 13:04:20 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=VhVtDyZG4Ub3GSWhq822jztVC1LDZ93THNr1krj2BmIMCvnNvv8+XKsxo9cz1Uloc 7Lzym/ed1NmB5i2vENkug== Message-ID: <4A7FAA42.4030607@delphij.net> Date: Sun, 09 Aug 2009 22:04:02 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.22 (X11/20090803) MIME-Version: 1.0 To: Doug Barton References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org> <4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org> In-Reply-To: <4A7F9EC6.9090605@FreeBSD.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org, d@delphij.net Subject: Re: [RFC] script for binding ARP <-> IP pairs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 05:05:22 -0000 Hi, Doug, Doug Barton wrote: > Xin LI wrote: > >> Thanks for your comments, I have put together the revised patch, along >> with rc.conf.5 and defaults/rc.conf changes. > > Glad to help. This looks fine except that you need an entry for > static_arp_enable in defaults rc.conf and rc.conf.5. This script does not require the enable knob. If the static_arp_pairs is not empty then the script would add the entries, otherwise it will not do that. Do you think we need an "enable" knob for it? I can add it but I don't feel strongly for the idea, since it would make a redundant entry to represent the same semantic. Cheers, -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve!