From owner-svn-src-head@freebsd.org Mon Jul 15 15:13:11 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD371BC616; Mon, 15 Jul 2019 15:13:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C081A95C88; Mon, 15 Jul 2019 15:13:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52b.google.com with SMTP id m4so7869093pgk.0; Mon, 15 Jul 2019 08:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0FZh01lAsPWgOWyw3IyqSRm1L0No6E9EMZ1gU0TyAEA=; b=AVA88EETGVAu4y/vtn7eNTRnOLF5NURW6yUKPyR1DgHIKPC49ckjfw04p9rCY/1Fzu 2TRUiy04dh3TEQqrDQIyjYGGwwC20jg0xtowmD2JwgVWMK6Db8bew4Jg95rwVbFsyCoJ jyz3Ey3FeUwPliG+YQ8b08VvDM946PEICEA6y5ZVnep8aRmCJz8VoVshCMftsbLFbCPC 2VuBBdYHStGb6GYczBtiWnYTL7WR7oontDqcj6Q3iAt38H8WXYY6wnxkqnlOrk+1MOiV GpL2s00Oisq02WGR6bKJHR8RO/fxtph+YcfDI+SkiGgC5BGhOd6Gl2Txq9BVVX3g8QXi DikQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0FZh01lAsPWgOWyw3IyqSRm1L0No6E9EMZ1gU0TyAEA=; b=MPx0cgEwZXnpJtP0MPpekwGl7MmJP8fahfj5tQLWXM5NOgar55mCoy1TfuuZ+AJ3K4 BaewECo9kU+gvZrTz+ykIODX4aG/MJQy9Yfjw5LsuM1RtE1drgGe9H1jlFLcVNVVdfAq ZvA36dy9lyBCS2W0ObR9k4Gw5XI9RD/Us5NsZ0TCi0TAfxKQbRAtmFYuKDBtnYDa1QIs GyiSucTKUCz/1ZmxHklSi8XC2HBO/DaHDHyXamzTqAfPGCLMQto/a0Wa19aMYodCuCvr ULe8EYGD+hiwuNnbjlTxt3UwTqQyJrev1bXqhT5OYgiAaVDcLK27pCQNPiHBqf3bi+72 M6hQ== X-Gm-Message-State: APjAAAW6KRpkUszInjxRJmF0wBZaw9yCI6PJYNIo/JD9dgtpltKu5tmn k9ntArOMWGb5REiJdSUPbc57Ql3HUBc= X-Google-Smtp-Source: APXvYqwSNOqSSWEl/zh7Xzvjo5ztxxl4dgnHffC7B+VKAQ5aTVGLBOh/6UpfL+1PxSqOFoAdozDIsw== X-Received: by 2002:a65:50cb:: with SMTP id s11mr27395436pgp.371.1563203589172; Mon, 15 Jul 2019 08:13:09 -0700 (PDT) Received: from [192.168.20.12] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id e124sm26068828pfh.181.2019.07.15.08.13.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 08:13:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r349996 - in head: sbin/ping usr.bin/telnet usr.sbin/inetd From: "Enji Cooper (yaneurabeya)" In-Reply-To: <201907151419.x6FEJeLf097263@repo.freebsd.org> Date: Mon, 15 Jul 2019 08:13:07 -0700 Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <91FDA4F0-2793-45F9-A5D0-35F03865A157@gmail.com> References: <201907151419.x6FEJeLf097263@repo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: C081A95C88 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=AVA88EET; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::52b as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.25 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.97)[-0.967,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.78)[ip: (-8.21), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.44), country: US(-0.06)]; RCVD_IN_DNSWL_NONE(0.00)[b.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 15:13:11 -0000 > On Jul 15, 2019, at 07:19, Warner Losh wrote: >=20 > Author: imp > Date: Mon Jul 15 14:19:39 2019 > New Revision: 349996 > URL: https://svnweb.freebsd.org/changeset/base/349996 >=20 > Log: > Remove all the RELEASE_CRUNCH instances that partially disable IPSEC >=20 > We remove IPSEC only in parts of the tree, and not others. = RELEASE_CRUNCH to > disable it has not kept up with all its uses. Remove it. Should there = be a real > need to disable IPSEC, one that hasn't shown up in the base system to = date, > it can be re-added behind a WITHOUT_IPSEC build option. =E2=80=A6 > Modified: head/usr.bin/telnet/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/usr.bin/telnet/Makefile Mon Jul 15 08:39:52 2019 = (r349995) > +++ head/usr.bin/telnet/Makefile Mon Jul 15 14:19:39 2019 = (r349996) > @@ -21,14 +21,8 @@ WARNS?=3D 2 >=20 > LIBADD=3D telnet ncursesw >=20 > -.if !defined(RELEASE_CRUNCH) > CFLAGS+=3D -DIPSEC > LIBADD+=3D ipsec > -.else > -.PATH: ${TELNETDIR}/libtelnet > -SRCS+=3D genget.c getent.c misc.c > -CFLAGS+=3D -DHAS_CGETENT > -.endif Hmmm=E2=80=A6 this is interesting. Why was cgetent/ipsec support = mutually exclusive=E2=80=A6 Thanks for cleaning this up :)! -Enji=