From owner-p4-projects@FreeBSD.ORG  Fri Dec 15 08:55:23 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1148D16A412; Fri, 15 Dec 2006 08:55:23 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DC1DF16A403
	for <perforce@freebsd.org>; Fri, 15 Dec 2006 08:55:22 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe02.swip.net [212.247.154.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A231743CEE
	for <perforce@freebsd.org>; Fri, 15 Dec 2006 08:53:39 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [193.217.134.54] (account mc467741@c2i.net HELO [10.0.0.249])
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.0.12)
	with ESMTPA id 359493552; Fri, 15 Dec 2006 09:55:17 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "M. Warner Losh" <imp@bsdimp.com>
Date: Fri, 15 Dec 2006 09:54:58 +0100
User-Agent: KMail/1.7
References: <200612131032.kBDAWXcE034886@repoman.freebsd.org>
	<20061214.222631.-345496069.imp@bsdimp.com>
In-Reply-To: <20061214.222631.-345496069.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200612150954.58930.hselasky@c2i.net>
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 111622 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2006 08:55:23 -0000

On Friday 15 December 2006 06:26, M. Warner Losh wrote:
> In message: <200612131032.kBDAWXcE034886@repoman.freebsd.org>
>
>             Hans Petter Selasky <hselasky@freebsd.org> writes:
> : http://perforce.freebsd.org/chv.cgi?CH=111622
> :
> : Change 111622 by hselasky@hselasky_mini_itx on 2006/12/13 10:31:33
> :
> :  Compile fix: Add missing dependency, vnode_if.h.
> :
> : Affected files ...
> :
> : .. //depot/projects/usb/src/sys/modules/ugen/Makefile#2 edit
> :
> : Differences ...
> :
> : ==== //depot/projects/usb/src/sys/modules/ugen/Makefile#2 (text+ko) ====
> :
> : @@ -3,6 +3,6 @@
> :  .PATH: ${.CURDIR}/../../dev/usb
> :
> :  KMOD= ugen
> : -SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h
> : +SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h vnode_if.h
>
> What does the usb driver need vnode_if.h for?  There was an old
> dependency on it, but it was elimianted.
>

I see that <sys/vnode.h> does no longer include "vnode_if.h". I added this 
bascially to get the code compiling on some older systems, where "vnode_if.h" 
is still included by <sys/vnode.h>. I will revert this, and keep the 
"vnode_if.h" patch in my SVN repo only.

--HPS