From owner-freebsd-bluetooth@FreeBSD.ORG  Thu Jan 15 09:51:51 2009
Return-Path: <owner-freebsd-bluetooth@FreeBSD.ORG>
Delivered-To: freebsd-bluetooth@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CDBF11065677
	for <freebsd-bluetooth@freebsd.org>;
	Thu, 15 Jan 2009 09:51:51 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe01.swip.net [212.247.154.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 662D98FC1D
	for <freebsd-bluetooth@freebsd.org>;
	Thu, 15 Jan 2009 09:51:51 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=nklthdr5v5AUSfVrlghuJA==:17
	a=wUzucHXjHoBfGvG_V-8A:9 a=g5Ie3j6nO3gFleqzldbO8-bbd0QA:4
	a=LY0hPdMaydYA:10
Received: from [62.113.132.62] (account mc467741@c2i.net [62.113.132.62]
	verified) by mailfe01.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 129542983; Thu, 15 Jan 2009 09:51:48 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com>
Date: Thu, 15 Jan 2009 09:54:10 +0100
User-Agent: KMail/1.9.7
References: <bb4a86c70901141705s1af508e3yf79383ecf97293cf@mail.gmail.com>
In-Reply-To: <bb4a86c70901141705s1af508e3yf79383ecf97293cf@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901150954.11454.hselasky@c2i.net>
Cc: "freebsd-bluetooth@freebsd.org" <freebsd-bluetooth@freebsd.org>,
	Alfred Perlstein <alfred@freebsd.org>
Subject: Re: USB2: ng_ubt2 patch
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
	<freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2009 09:51:52 -0000

On Thursday 15 January 2009, Maksim Yevmenkin wrote:
> dear bluetooth users,
>
> please find attached patch for ng_ubt2 (well it is almost a complete
> rewrite).
>
> this is an early preview and likely to have bugs. i briefly kicked the
> tires to make sure it compiles and did some very quick testing, i.e.
> run few hci commands, sdp transfers etc.
>
> this is my first attempt to write something under usb2, so any
> review/comments/suggestions/etc. are greatly appreciated.
>
> thanks,
> max

Hi,

This looks very interesting.

1) Maybe you just want to merge together all the USB config structures into 
one?

2) There are some isochronous details for non-Full speed USB. UBT_ISOC_NFRAMES 
must be a factor of 8 if it should work.

How much bluetooth functionality have you tested?

BTW: I think your patch is pretty Ok. Is what you attached the final version 
of your patch?

--HPS