From owner-freebsd-emulation@freebsd.org Fri Jun 15 07:23:09 2018 Return-Path: Delivered-To: freebsd-emulation@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8F7A1002A83 for ; Fri, 15 Jun 2018 07:23:08 +0000 (UTC) (envelope-from yanko.yankulov@gmail.com) Received: from mail-ot0-x22e.google.com (mail-ot0-x22e.google.com [IPv6:2607:f8b0:4003:c0f::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 61FFC7DC7F for ; Fri, 15 Jun 2018 07:23:08 +0000 (UTC) (envelope-from yanko.yankulov@gmail.com) Received: by mail-ot0-x22e.google.com with SMTP id w13-v6so9963280ote.11 for ; Fri, 15 Jun 2018 00:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ami+hA+VFXw7Cu90raGcLvvAchEyWL2GPZWjblzu6sk=; b=kVxmiXKIRJUqYSCLJSy3SKlSkLtDGtL/wjWLgzH3vFSb/rzDpC69u1Og2Uptb3oJw4 3xDxqpSMj2EokZdxhFhe3RIpBo0bGoYOhQ6NVxp8pQ3hHXiU9OMshJ7zAYxZXapQBD89 7mPX/TSbjO13xuf6KjTeH6w1ocpnxsLzgA5iG2ca5Ltfdf3jO5Rn9lNpg3TePiw4ypWk 2SUAFZNkvI8Oiux94fDWS1Yc7qWc2b1OZrGb82M4H61oD4RTiQBaGr+bJkIk+8H93ObM CwwwxZrQagypnHPIf2aHL937d+xBtXrMzSRwK7QWsTdvmb8/sIMhMz5si8zzMbHL5lzJ c8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ami+hA+VFXw7Cu90raGcLvvAchEyWL2GPZWjblzu6sk=; b=NrK3DZ3Eaj9zwFGVO77JRWYBDdxPjdlGVBkF+UYOgB83KP6jit0j1ht3g8XjpFzqGh m0eqRObc5r53YcgT+LPDyXIVXSvNvtWk/kr6BL3/dSZTrNwhEdBUhrTuIPD++RbogNX4 1MviRj1pe81zTFwYddVTJ7He0WVMxMDJJF5hBVWhIzU+JnK1jqLK29ammNUFxrHLR6J6 z+K1puU7fv5kZdJRTgV9oJOYJAp6r8XoDNlcU9SmvQ4Df/Kqhc6fEAG1QfthluFOxJjV IvZKTMfptny3+CDzxOooOY5TWuKc4rzHac0Iz53Nzj/Exe6YjpNv2mzl6gSEy++N9wSh vv8w== X-Gm-Message-State: APt69E0dpq6UBSaIU4lTunlrjPHm4u5IVUpXd0GD06dXCZTxeEF5v6Wh V+wTzIUMnQH2a4U/1G9lZJlx3OYDeW6HWIXnSME= X-Google-Smtp-Source: ADUXVKKmUyVVyZ0q0hCbVzNFcr7KY+05rL8wR4ltSuxkN8owEbHcpGAcHxdu+hxfRhzvoAP2AL9LelNVpQyFyvnmwxU= X-Received: by 2002:a9d:72dd:: with SMTP id d29-v6mr314539otk.345.1529047387439; Fri, 15 Jun 2018 00:23:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:14cd:0:0:0:0:0 with HTTP; Fri, 15 Jun 2018 00:23:06 -0700 (PDT) In-Reply-To: <20180614141604.GA2493@kib.kiev.ua> References: <20180614101324.GW2493@kib.kiev.ua> <20180614123659.GZ2493@kib.kiev.ua> <20180614141604.GA2493@kib.kiev.ua> From: Yanko Yankulov Date: Fri, 15 Jun 2018 10:23:06 +0300 Message-ID: Subject: Re: two proposed linuxulator fixes + ptrace To: Konstantin Belousov Cc: freebsd-emulation@freebsd.org Content-Type: multipart/mixed; boundary="000000000000616e1f056ea91635" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 07:23:09 -0000 --000000000000616e1f056ea91635 Content-Type: text/plain; charset="UTF-8" Thanks for the hint. It turned that we already have all the info due to the call to fill_kinfo_proc(p, &kp); Proper patch attached. Verified with the ptrace patch, that correct values are reported in PPid & TracerPid. Regarding the ptrace patch - for some reason I am not receiving a registration mail from reviews.freebsd.org so I am a bit stuck. Best, On Thu, Jun 14, 2018 at 5:16 PM, Konstantin Belousov wrote: > On Thu, Jun 14, 2018 at 04:11:52PM +0300, Yanko Yankulov wrote: > > > > > For the patch 1, TracePid, can you explain what is the meaning of > the > > > > > pid reported ? > > > > > > > > > > The TracerPid is the PID of the process currently ptrace-ing the > > > process. > > > > TracerPid 0 means no active tracer. So the patch is not semantically > > > > correct as it always reports no tracer, but it got the program > running. > > > Ok, but what is the tracer ? Is it ptrace(2) debugger, or something > > > else ? > > > > > > > Yes, any ptrace(2) debugger/truss/strace/whatever. The Linux code is: > > > > tracer = ptrace_parent(p); > > if (tracer) > > tpid = task_pid_nr_ns(tracer, ns); > > I think this should be like > PROC_LOCK(p); > tpid = (p->p_flag & P_TRACED) != 0 ? p->p_ppid : 0; > PROC_UNLOCK(p); > sx_slock(&proctree_lock); > parent_pid = proc_realparent(p)->p_pid; > sx_sunlock(&proctree_lock); > --000000000000616e1f056ea91635 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-linprocfs-proc-pid-status-add-TracerPid.patch" Content-Disposition: attachment; filename="0001-linprocfs-proc-pid-status-add-TracerPid.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jifn0it40 RnJvbSA0MmZkZDhiNjQwM2U4YTAzNjExY2NiYThhMGQ3NWFhOWJmZTI1M2I4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZYW5rbyBZYW5rdWxvdiA8eWFua28ueWFua3Vsb3ZAZ21haWwu Y29tPgpEYXRlOiBUaHUsIDE0IEp1biAyMDE4IDEwOjQ0OjIyICswMzAwClN1YmplY3Q6IFtQQVRD SF0gbGlucHJvY2ZzOiAvcHJvYy9waWQvc3RhdHVzIGFkZCBUcmFjZXJQaWQKCkFuZCByZXR1cm4g cmVhbCBwYXJlbnQgaWYgdHJhY2VkCi0tLQogc3lzL2NvbXBhdC9saW5wcm9jZnMvbGlucHJvY2Zz LmMgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3lzL2NvbXBhdC9saW5wcm9jZnMvbGlucHJvY2ZzLmMgYi9zeXMv Y29tcGF0L2xpbnByb2Nmcy9saW5wcm9jZnMuYwppbmRleCA1ODYyNTlmMjgzMTUuLjI0OTJhYmZm ZWJiOSAxMDA2NDQKLS0tIGEvc3lzL2NvbXBhdC9saW5wcm9jZnMvbGlucHJvY2ZzLmMKKysrIGIv c3lzL2NvbXBhdC9saW5wcm9jZnMvbGlucHJvY2ZzLmMKQEAgLTgwMyw4ICs4MDMsOCBAQCBsaW5w cm9jZnNfZG9wcm9jc3RhdHVzKFBGU19GSUxMX0FSR1MpCiAJICogQ3JlZGVudGlhbHMKIAkgKi8K IAlzYnVmX3ByaW50ZihzYiwgIlBpZDpcdCVkXG4iLAkJcC0+cF9waWQpOwotCXNidWZfcHJpbnRm KHNiLCAiUFBpZDpcdCVkXG4iLAkJcC0+cF9wcHRyID8KLQkJCQkJCXAtPnBfcHB0ci0+cF9waWQg OiAwKTsKKwlzYnVmX3ByaW50ZihzYiwgIlBQaWQ6XHQlZFxuIiwJCWtwLmtpX3BwaWQgKTsKKwlz YnVmX3ByaW50ZihzYiwgIlRyYWNlclBpZDpcdCVkXG4iLAlrcC5raV90cmFjZXIgKTsKIAlzYnVm X3ByaW50ZihzYiwgIlVpZDpcdCVkICVkICVkICVkXG4iLAlwLT5wX3VjcmVkLT5jcl9ydWlkLAog CQkJCQkJcC0+cF91Y3JlZC0+Y3JfdWlkLAogCQkJCQkJcC0+cF91Y3JlZC0+Y3Jfc3Z1aWQsCi0t IAoyLjE3LjEKCg== --000000000000616e1f056ea91635--